Value sanitization for input[type=text] should not truncate a value at control character

Value sanitization for input[type=text] should not truncate a value at control character

The new behavior is compatible with IE and Firefox.

R=tkent, keishi1
BUG=261846
TEST=automated

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168989

[Habib Virji, 2014-03-07 15:51:01]

Support for text sanitization to not remove truncate string if VT present.

[tkent, 2014-03-07 17:26:34]

https://codereview.chromium.org/189843008/diff/1/Source/core/html/forms/TextF...
File Source/core/html/forms/TextFieldInputType.cpp (right):

https://codereview.chromium.org/189843008/diff/1/Source/core/html/forms/TextF...
Source/core/html/forms/TextFieldInputType.cpp:406: if (current < ' ' && current
!= '\t' && current != '\v') {
Please follow the FIXME comment above.

[Habib Virji, 2014-03-10 12:02:56]

Firefox just truncates \r and \n, which. No control character is removed from
the string. 

Test updated to include test for most of the control characters.

https://codereview.chromium.org/189843008/diff/1/Source/core/html/forms/TextF...
File Source/core/html/forms/TextFieldInputType.cpp (right):

https://codereview.chromium.org/189843008/diff/1/Source/core/html/forms/TextF...
Source/core/html/forms/TextFieldInputType.cpp:406: if (current < ' ' && current
!= '\t' && current != '\v') {
On 2014/03/07 17:26:34, tkent wrote:
> Please follow the FIXME comment above.

Done.

[tkent, 2014-03-11 04:03:06]

> Control character can now be included in string as in case of IE and firefox. 

Hard to understand this summary.
How about:
"
Value sanitization for input[type=text] should not truncate a value at control
characters.

The new behavior is compatible with IE and Firefox.

BUG=...
"

https://codereview.chromium.org/189843008/diff/20001/LayoutTests/fast/forms/i...
File LayoutTests/fast/forms/input-value-sanitization.html (right):

https://codereview.chromium.org/189843008/diff/20001/LayoutTests/fast/forms/i...
LayoutTests/fast/forms/input-value-sanitization.html:58: input.value="foo\0bar";
Please add spaces around '='.

https://codereview.chromium.org/189843008/diff/20001/LayoutTests/fast/forms/i...
LayoutTests/fast/forms/input-value-sanitization.html:59: shouldBe('input.value',
'"foo\\0bar"');
Please use shouldBeEqualToString.

[Habib Virji, 2014-03-11 11:17:49]

Thanks for the summary. Updated.

https://codereview.chromium.org/189843008/diff/20001/LayoutTests/fast/forms/i...
File LayoutTests/fast/forms/input-value-sanitization.html (right):

https://codereview.chromium.org/189843008/diff/20001/LayoutTests/fast/forms/i...
LayoutTests/fast/forms/input-value-sanitization.html:58: input.value="foo\0bar";
On 2014/03/11 04:03:06, tkent wrote:
> Please add spaces around '='.

Done.

https://codereview.chromium.org/189843008/diff/20001/LayoutTests/fast/forms/i...
LayoutTests/fast/forms/input-value-sanitization.html:59: shouldBe('input.value',
'"foo\\0bar"');
On 2014/03/11 04:03:06, tkent wrote:
> Please use shouldBeEqualToString.

Done.

[tkent, 2014-03-11 22:40:00]

lgtm

[commit-bot: I haz the power, 2014-03-11 22:40:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/habib.virji@samsung.com/189843008/40001

[commit-bot: I haz the power, 2014-03-12 02:35:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-12 02:35:17]

Try jobs failed on following builders: linux_blink

[tkent, 2014-03-12 03:08:03]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-03-12 03:08:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/habib.virji@samsung.com/189843008/40001

[commit-bot: I haz the power, 2014-03-12 06:50:31]

Change committed as 168986

[tkent, 2014-03-12 06:54:16]

On 2014/03/12 06:50:31, I haz the power (commit-bot) wrote:
> Change committed as 168986

The CL description missed the summary line.  I'll revert.

[tkent, 2014-03-12 06:54:38]

A revert of this CL has been created in
https://codereview.chromium.org/196413004/ by tkent@chromium.org.

The reason for reverting is: Wrong CL description.
.

[tkent, 2014-03-12 06:57:17]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-03-12 06:57:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/habib.virji@samsung.com/189843008/40001

[commit-bot: I haz the power, 2014-03-12 06:57:46]

Change committed as 168989

[Habib Virji, 2014-03-12 10:55:02]

On 2014/03/12 06:54:38, tkent wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/196413004/ by mailto:tkent@chromium.org.
> 
> The reason for reverting is: Wrong CL description.
> .
Thanks. I did update the issue, do I need to update commit log too? (Sorry for
stupid question but want to know it for next time).

[tkent, 2014-03-13 01:18:47]

On 2014/03/12 10:55:02, Habib Virji wrote:
> On 2014/03/12 06:54:38, tkent wrote:
> > A revert of this CL has been created in
> > https://codereview.chromium.org/196413004/ by mailto:tkent@chromium.org.
> > 
> > The reason for reverting is: Wrong CL description.
> > .
> Thanks. I did update the issue, do I need to update commit log too? (Sorry for
> stupid question but want to know it for next time).

We can't update the commit log.  So I reverted r168986, which had a wrong CL
description, update the CL description in this codereview, then asked CQ to
commit it. CQ landed it as 168989.  You don't need to do nothing now.

"Description" field in a codereview will be actual commit log. "Subject" field
is not committed at all. So "Description" field must contain the summary line.