Issue 1898393003: [Merge M51] aw: Fix AwGLFunctor lifetime object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1898393003: [Merge M51] aw: Fix AwGLFunctor lifetime object (Closed)

Created:
4 years, 8 months ago by boliu

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

[Merge M51] aw: Fix AwGLFunctor lifetime object CleanupReference can't use the DestroyRunnable as the referent, since CleanupReference itself is a gc root that will keep DestroyRunnable alive, in which case the referent is never garbage collected. BUG=597167 Review URL: https://codereview.chromium.org/1905623002 Cr-Commit-Position: refs/heads/master@{#388518} (cherry picked from commit 5160fb439dc0ba515c6708a7d96dc88ebd14bb11) Committed: https://chromium.googlesource.com/chromium/src/+/0f00382fbdc076d93bd0a04b7b7dfba4116a97fd

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	android_webview/java/src/org/chromium/android_webview/AwGLFunctor.java	View		3 chunks	+6 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

boliu

4 years, 8 months ago (2016-04-20 17:01:49 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0f00382fbdc076d93bd0a04b7b7dfba4116a97fd.