Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1905623002: aw: Fix AwGLFunctor lifetime object (Closed)

Created:
4 years, 8 months ago by boliu
Modified:
4 years, 8 months ago
Reviewers:
Tobias Sargeant
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Fix AwGLFunctor lifetime object CleanupReference can't use the DestroyRunnable as the referent, since CleanupReference itself is a gc root that will keep DestroyRunnable alive, in which case the referent is never garbage collected. BUG=597167 Committed: https://crrev.com/5160fb439dc0ba515c6708a7d96dc88ebd14bb11 Cr-Commit-Position: refs/heads/master@{#388518}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwGLFunctor.java View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
boliu
fix \o/
4 years, 8 months ago (2016-04-20 15:23:56 UTC) #2
Tobias Sargeant
On 2016/04/20 15:23:56, boliu wrote: > fix \o/ nice, LGTM.
4 years, 8 months ago (2016-04-20 15:27:09 UTC) #3
boliu
On 2016/04/20 15:27:09, Tobias Sargeant wrote: > On 2016/04/20 15:23:56, boliu wrote: > > fix ...
4 years, 8 months ago (2016-04-20 15:28:40 UTC) #4
boliu
On 2016/04/20 15:28:40, boliu wrote: > On 2016/04/20 15:27:09, Tobias Sargeant wrote: > > On ...
4 years, 8 months ago (2016-04-20 15:46:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905623002/1
4 years, 8 months ago (2016-04-20 15:47:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 16:35:35 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:24:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5160fb439dc0ba515c6708a7d96dc88ebd14bb11
Cr-Commit-Position: refs/heads/master@{#388518}

Powered by Google App Engine
This is Rietveld 408576698