Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1898393002: Fixed-position elements should not be clipped by ancestor fixed-position overflow clip (Closed)

Created:
4 years, 8 months ago by trchen
Modified:
4 years, 8 months ago
Reviewers:
Ian Vollick
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed-position elements should not be clipped by ancestor fixed-position overflow clip The behavior was divergent between WebKit and Mozilla. Blink used to match WebKit behavior, but now its non-compositing code path matches Mozilla. The compositing code path should match the non-compositing one. BUG=600605 TEST=compositing/overflow/fixed-element-escape-fixed-overflow-clip.html Committed: https://crrev.com/8fa1bf1541ea2a52b8c2a6717ab135eac7c02471 Cr-Commit-Position: refs/heads/master@{#388426}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -7 lines) Patch
A third_party/WebKit/LayoutTests/compositing/overflow/fixed-element-escape-fixed-overflow-clip.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/compositing/overflow/fixed-element-escape-fixed-overflow-clip-expected.html View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898393002/1
4 years, 8 months ago (2016-04-20 01:34:19 UTC) #4
trchen
4 years, 8 months ago (2016-04-20 01:35:56 UTC) #5
Ian Vollick
On 2016/04/20 01:35:56, trchen wrote: lgtm.
4 years, 8 months ago (2016-04-20 02:10:28 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 03:09:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898393002/1
4 years, 8 months ago (2016-04-20 03:53:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 03:57:57 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:20:53 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fa1bf1541ea2a52b8c2a6717ab135eac7c02471
Cr-Commit-Position: refs/heads/master@{#388426}

Powered by Google App Engine
This is Rietveld 408576698