Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

Issue 1898393002: Fixed-position elements should not be clipped by ancestor fixed-position overflow clip (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/overflow/fixed-element-escape-fixed-overflow-clip-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
index c823e20b596812da42f09521694149aecc0a71ba..21452394cd97688b1adb81f32912238736aa6c97 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
@@ -36,13 +36,6 @@ static const PaintLayer* findParentLayerOnClippingContainerChain(const PaintLaye
while (current) {
if (current->style()->position() == FixedPosition) {
for (current = current->parent(); current && !current->canContainFixedPositionObjects(); current = current->parent()) {
- // All types of clips apply to fixed-position descendants of other fixed-position elements.
- // Note: it's unclear whether this is what the spec says. Firefox does not clip, but Chrome does.
- if (current->style()->position() == FixedPosition && current->hasClipRelatedProperty()) {
- ASSERT(current->hasLayer());
- return static_cast<const LayoutBoxModelObject*>(current)->layer();
- }
-
// CSS clip applies to fixed position elements even for ancestors that are not what the
// fixed element is positioned with respect to.
if (current->hasClip()) {
« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/overflow/fixed-element-escape-fixed-overflow-clip-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698