Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 1898293003: Make MultiColumnFragmentainerGroup::m_columnSet const. (Closed)

Created:
4 years, 8 months ago by mstensho (USE GERRIT)
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make MultiColumnFragmentainerGroup::m_columnSet const. Ideally, I'd like to get rid of the member altogether, but that would require a lot of refactoring. This is a preparatory patch for a fix for bug 604609. BUG=604609 Committed: https://crrev.com/69b27e85cdf52da2d0be4f011b92b77c461e12ab Cr-Commit-Position: refs/heads/master@{#388326}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h View 3 chunks +3 lines, -3 lines 2 comments Download
M third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
https://codereview.chromium.org/1898293003/diff/1/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h File third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h (right): https://codereview.chromium.org/1898293003/diff/1/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h#newcode63 third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h:63: bool recalculateColumnHeight(LayoutMultiColumnSet&); So, how silly is this? I need ...
4 years, 8 months ago (2016-04-19 19:07:40 UTC) #2
leviw_travelin_and_unemployed
https://codereview.chromium.org/1898293003/diff/1/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h File third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h (right): https://codereview.chromium.org/1898293003/diff/1/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h#newcode63 third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h:63: bool recalculateColumnHeight(LayoutMultiColumnSet&); On 2016/04/19 at 19:07:39, mstensho wrote: > ...
4 years, 8 months ago (2016-04-19 19:57:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898293003/1
4 years, 8 months ago (2016-04-19 20:05:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 22:11:03 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:16:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69b27e85cdf52da2d0be4f011b92b77c461e12ab
Cr-Commit-Position: refs/heads/master@{#388326}

Powered by Google App Engine
This is Rietveld 408576698