Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp

Issue 1898293003: Make MultiColumnFragmentainerGroup::m_columnSet const. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp
diff --git a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp
index e2fae001494443f1b73553c66da12291d449c651..855466f5e33581657916974c04e61affd2728da2 100644
--- a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp
+++ b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp
@@ -10,7 +10,7 @@
namespace blink {
-MultiColumnFragmentainerGroup::MultiColumnFragmentainerGroup(LayoutMultiColumnSet& columnSet)
+MultiColumnFragmentainerGroup::MultiColumnFragmentainerGroup(const LayoutMultiColumnSet& columnSet)
: m_columnSet(columnSet)
{
}
@@ -57,7 +57,7 @@ void MultiColumnFragmentainerGroup::resetColumnHeight()
}
}
-bool MultiColumnFragmentainerGroup::recalculateColumnHeight()
+bool MultiColumnFragmentainerGroup::recalculateColumnHeight(LayoutMultiColumnSet& columnSet)
{
LayoutUnit oldColumnHeight = m_columnHeight;
@@ -66,18 +66,18 @@ bool MultiColumnFragmentainerGroup::recalculateColumnHeight()
// Only the last row may have auto height, and thus be balanced. There are no good reasons to
// balance the preceding rows, and that could potentially lead to an insane number of layout
// passes as well.
- if (isLastGroup() && m_columnSet.heightIsAuto()) {
+ if (isLastGroup() && columnSet.heightIsAuto()) {
LayoutUnit newColumnHeight;
- if (!m_columnSet.isInitialHeightCalculated()) {
+ if (!columnSet.isInitialHeightCalculated()) {
// Initial balancing: Start with the lowest imaginable column height. Also calculate the
// height of the tallest piece of unbreakable content. Columns should never get any
// shorter than that (unless constrained by max-height). Propagate this to our
// containing column set, in case there is an outer multicol container that also needs
// to balance. After having calculated the initial column height, the multicol container
// needs another layout pass with the column height that we just calculated.
- InitialColumnHeightFinder initialHeightFinder(columnSet(), logicalTopInFlowThread(), logicalBottomInFlowThread());
+ InitialColumnHeightFinder initialHeightFinder(columnSet, logicalTopInFlowThread(), logicalBottomInFlowThread());
LayoutUnit tallestUnbreakableLogicalHeight = initialHeightFinder.tallestUnbreakableLogicalHeight();
- m_columnSet.propagateTallestUnbreakableLogicalHeight(tallestUnbreakableLogicalHeight);
+ columnSet.propagateTallestUnbreakableLogicalHeight(tallestUnbreakableLogicalHeight);
newColumnHeight = std::max(initialHeightFinder.initialMinimalBalancedHeight(), tallestUnbreakableLogicalHeight);
} else {
// Rebalancing: After having laid out again, we'll need to rebalance if the height

Powered by Google App Engine
This is Rietveld 408576698