Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: components/scheduler/renderer/renderer_scheduler_impl.h

Issue 1898233002: Report expected task queueing time via UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: RenderSchedulerImpl owns all the things. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/renderer/renderer_scheduler_impl.h
diff --git a/components/scheduler/renderer/renderer_scheduler_impl.h b/components/scheduler/renderer/renderer_scheduler_impl.h
index 0f9d623b11c22a2c3d9ddd7891c286e7062b2dcf..0d5063256c019a5d30aeffbf00f9dc0981750848 100644
--- a/components/scheduler/renderer/renderer_scheduler_impl.h
+++ b/components/scheduler/renderer/renderer_scheduler_impl.h
@@ -9,6 +9,7 @@
#include "base/macros.h"
#include "base/synchronization/lock.h"
#include "components/scheduler/base/pollable_thread_safe_flag.h"
+#include "components/scheduler/base/task_time_tracker.h"
#include "components/scheduler/child/idle_helper.h"
#include "components/scheduler/child/scheduler_helper.h"
#include "components/scheduler/renderer/deadline_task_runner.h"
@@ -36,7 +37,9 @@ class SCHEDULER_EXPORT RendererSchedulerImpl
: public RendererScheduler,
public IdleHelper::Delegate,
public SchedulerHelper::Observer,
- public RenderWidgetSignals::Observer {
+ public RenderWidgetSignals::Observer,
+ public TaskTimeTracker::Observer,
+ public QueueingTimeEstimator::Client {
public:
// Keep RendererScheduler::UseCaseToString in sync with this enum.
enum class UseCase {
@@ -126,6 +129,13 @@ class SCHEDULER_EXPORT RendererSchedulerImpl
void OnTriedToExecuteBlockedTask(const TaskQueue& queue,
const base::PendingTask& task) override;
+ // TaskTimeTracker::Observer implementation:
+ void ReportTaskTime(base::TimeTicks start_time,
+ base::TimeTicks end_time) override;
+
+ // QueueingTimeEstimator::Client implementation:
+ void OnQueueingTimeForWindowEstimated(base::TimeDelta queueing_time) override;
+
// Returns a task runner where tasks run at the highest possible priority.
scoped_refptr<TaskQueue> ControlTaskRunner();
@@ -333,6 +343,7 @@ class SCHEDULER_EXPORT RendererSchedulerImpl
SchedulerHelper helper_;
IdleHelper idle_helper_;
+ TaskTimeTracker task_time_tracker_;
std::unique_ptr<ThrottlingHelper> throttling_helper_;
RenderWidgetSignals render_widget_scheduler_signals_;
@@ -352,12 +363,14 @@ class SCHEDULER_EXPORT RendererSchedulerImpl
// (the accessors) for the following data members.
struct MainThreadOnly {
- MainThreadOnly(const scoped_refptr<TaskQueue>& compositor_task_runner,
+ MainThreadOnly(RendererSchedulerImpl* renderer_scheduler_impl,
+ const scoped_refptr<TaskQueue>& compositor_task_runner,
base::TickClock* time_source);
~MainThreadOnly();
TaskCostEstimator loading_task_cost_estimator;
TaskCostEstimator timer_task_cost_estimator;
+ QueueingTimeEstimator queueing_time_estimator;
IdleTimeEstimator idle_time_estimator;
UseCase current_use_case;
Policy current_policy;

Powered by Google App Engine
This is Rietveld 408576698