Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: components/scheduler/renderer/renderer_scheduler_impl.h

Issue 1898233002: Report expected task queueing time via UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: RenderSchedulerImpl owns all the things. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SCHEDULER_RENDERER_RENDERER_SCHEDULER_IMPL_H_ 5 #ifndef COMPONENTS_SCHEDULER_RENDERER_RENDERER_SCHEDULER_IMPL_H_
6 #define COMPONENTS_SCHEDULER_RENDERER_RENDERER_SCHEDULER_IMPL_H_ 6 #define COMPONENTS_SCHEDULER_RENDERER_RENDERER_SCHEDULER_IMPL_H_
7 7
8 #include "base/atomicops.h" 8 #include "base/atomicops.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/synchronization/lock.h" 10 #include "base/synchronization/lock.h"
11 #include "components/scheduler/base/pollable_thread_safe_flag.h" 11 #include "components/scheduler/base/pollable_thread_safe_flag.h"
12 #include "components/scheduler/base/task_time_tracker.h"
12 #include "components/scheduler/child/idle_helper.h" 13 #include "components/scheduler/child/idle_helper.h"
13 #include "components/scheduler/child/scheduler_helper.h" 14 #include "components/scheduler/child/scheduler_helper.h"
14 #include "components/scheduler/renderer/deadline_task_runner.h" 15 #include "components/scheduler/renderer/deadline_task_runner.h"
15 #include "components/scheduler/renderer/idle_time_estimator.h" 16 #include "components/scheduler/renderer/idle_time_estimator.h"
16 #include "components/scheduler/renderer/render_widget_signals.h" 17 #include "components/scheduler/renderer/render_widget_signals.h"
17 #include "components/scheduler/renderer/renderer_scheduler.h" 18 #include "components/scheduler/renderer/renderer_scheduler.h"
18 #include "components/scheduler/renderer/task_cost_estimator.h" 19 #include "components/scheduler/renderer/task_cost_estimator.h"
19 #include "components/scheduler/renderer/throttling_helper.h" 20 #include "components/scheduler/renderer/throttling_helper.h"
20 #include "components/scheduler/renderer/user_model.h" 21 #include "components/scheduler/renderer/user_model.h"
21 #include "components/scheduler/renderer/web_view_scheduler_impl.h" 22 #include "components/scheduler/renderer/web_view_scheduler_impl.h"
22 #include "components/scheduler/scheduler_export.h" 23 #include "components/scheduler/scheduler_export.h"
23 24
24 namespace base { 25 namespace base {
25 namespace trace_event { 26 namespace trace_event {
26 class ConvertableToTraceFormat; 27 class ConvertableToTraceFormat;
27 } 28 }
28 } 29 }
29 30
30 namespace scheduler { 31 namespace scheduler {
31 class RenderWidgetSchedulingState; 32 class RenderWidgetSchedulingState;
32 class WebViewSchedulerImpl; 33 class WebViewSchedulerImpl;
33 class ThrottlingHelper; 34 class ThrottlingHelper;
34 35
35 class SCHEDULER_EXPORT RendererSchedulerImpl 36 class SCHEDULER_EXPORT RendererSchedulerImpl
36 : public RendererScheduler, 37 : public RendererScheduler,
37 public IdleHelper::Delegate, 38 public IdleHelper::Delegate,
38 public SchedulerHelper::Observer, 39 public SchedulerHelper::Observer,
39 public RenderWidgetSignals::Observer { 40 public RenderWidgetSignals::Observer,
41 public TaskTimeTracker::Observer,
42 public QueueingTimeEstimator::Client {
40 public: 43 public:
41 // Keep RendererScheduler::UseCaseToString in sync with this enum. 44 // Keep RendererScheduler::UseCaseToString in sync with this enum.
42 enum class UseCase { 45 enum class UseCase {
43 // No active use case detected. 46 // No active use case detected.
44 NONE, 47 NONE,
45 // A continuous gesture (e.g., scroll, pinch) which is being driven by the 48 // A continuous gesture (e.g., scroll, pinch) which is being driven by the
46 // compositor thread. 49 // compositor thread.
47 COMPOSITOR_GESTURE, 50 COMPOSITOR_GESTURE,
48 // An unspecified touch gesture which is being handled by the main thread. 51 // An unspecified touch gesture which is being handled by the main thread.
49 // Note that since we don't have a full view of the use case, we should be 52 // Note that since we don't have a full view of the use case, we should be
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 // RenderWidgetSignals::Observer implementation: 122 // RenderWidgetSignals::Observer implementation:
120 void SetAllRenderWidgetsHidden(bool hidden) override; 123 void SetAllRenderWidgetsHidden(bool hidden) override;
121 void SetHasVisibleRenderWidgetWithTouchHandler( 124 void SetHasVisibleRenderWidgetWithTouchHandler(
122 bool has_visible_render_widget_with_touch_handler) override; 125 bool has_visible_render_widget_with_touch_handler) override;
123 126
124 // SchedulerHelper::Observer implementation: 127 // SchedulerHelper::Observer implementation:
125 void OnUnregisterTaskQueue(const scoped_refptr<TaskQueue>& queue) override; 128 void OnUnregisterTaskQueue(const scoped_refptr<TaskQueue>& queue) override;
126 void OnTriedToExecuteBlockedTask(const TaskQueue& queue, 129 void OnTriedToExecuteBlockedTask(const TaskQueue& queue,
127 const base::PendingTask& task) override; 130 const base::PendingTask& task) override;
128 131
132 // TaskTimeTracker::Observer implementation:
133 void ReportTaskTime(base::TimeTicks start_time,
134 base::TimeTicks end_time) override;
135
136 // QueueingTimeEstimator::Client implementation:
137 void OnQueueingTimeForWindowEstimated(base::TimeDelta queueing_time) override;
138
129 // Returns a task runner where tasks run at the highest possible priority. 139 // Returns a task runner where tasks run at the highest possible priority.
130 scoped_refptr<TaskQueue> ControlTaskRunner(); 140 scoped_refptr<TaskQueue> ControlTaskRunner();
131 141
132 void RegisterTimeDomain(TimeDomain* time_domain); 142 void RegisterTimeDomain(TimeDomain* time_domain);
133 void UnregisterTimeDomain(TimeDomain* time_domain); 143 void UnregisterTimeDomain(TimeDomain* time_domain);
134 144
135 void SetExpensiveTaskBlockingAllowed(bool allowed); 145 void SetExpensiveTaskBlockingAllowed(bool allowed);
136 146
137 void AddWebViewScheduler(WebViewSchedulerImpl* web_view_scheduler); 147 void AddWebViewScheduler(WebViewSchedulerImpl* web_view_scheduler);
138 void RemoveWebViewScheduler(WebViewSchedulerImpl* web_view_scheduler); 148 void RemoveWebViewScheduler(WebViewSchedulerImpl* web_view_scheduler);
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 336
327 void ApplyTaskQueuePolicy(TaskQueue* task_queue, 337 void ApplyTaskQueuePolicy(TaskQueue* task_queue,
328 const TaskQueuePolicy& old_task_queue_policy, 338 const TaskQueuePolicy& old_task_queue_policy,
329 const TaskQueuePolicy& new_task_queue_policy) const; 339 const TaskQueuePolicy& new_task_queue_policy) const;
330 340
331 static const char* ExpensiveTaskPolicyToString( 341 static const char* ExpensiveTaskPolicyToString(
332 ExpensiveTaskPolicy expensive_task_policy); 342 ExpensiveTaskPolicy expensive_task_policy);
333 343
334 SchedulerHelper helper_; 344 SchedulerHelper helper_;
335 IdleHelper idle_helper_; 345 IdleHelper idle_helper_;
346 TaskTimeTracker task_time_tracker_;
336 std::unique_ptr<ThrottlingHelper> throttling_helper_; 347 std::unique_ptr<ThrottlingHelper> throttling_helper_;
337 RenderWidgetSignals render_widget_scheduler_signals_; 348 RenderWidgetSignals render_widget_scheduler_signals_;
338 349
339 const scoped_refptr<TaskQueue> control_task_runner_; 350 const scoped_refptr<TaskQueue> control_task_runner_;
340 const scoped_refptr<TaskQueue> compositor_task_runner_; 351 const scoped_refptr<TaskQueue> compositor_task_runner_;
341 std::set<scoped_refptr<TaskQueue>> loading_task_runners_; 352 std::set<scoped_refptr<TaskQueue>> loading_task_runners_;
342 std::set<scoped_refptr<TaskQueue>> timer_task_runners_; 353 std::set<scoped_refptr<TaskQueue>> timer_task_runners_;
343 scoped_refptr<TaskQueue> default_loading_task_runner_; 354 scoped_refptr<TaskQueue> default_loading_task_runner_;
344 scoped_refptr<TaskQueue> default_timer_task_runner_; 355 scoped_refptr<TaskQueue> default_timer_task_runner_;
345 356
346 base::Closure update_policy_closure_; 357 base::Closure update_policy_closure_;
347 DeadlineTaskRunner delayed_update_policy_runner_; 358 DeadlineTaskRunner delayed_update_policy_runner_;
348 CancelableClosureHolder end_renderer_hidden_idle_period_closure_; 359 CancelableClosureHolder end_renderer_hidden_idle_period_closure_;
349 CancelableClosureHolder suspend_timers_when_backgrounded_closure_; 360 CancelableClosureHolder suspend_timers_when_backgrounded_closure_;
350 361
351 // We have decided to improve thread safety at the cost of some boilerplate 362 // We have decided to improve thread safety at the cost of some boilerplate
352 // (the accessors) for the following data members. 363 // (the accessors) for the following data members.
353 364
354 struct MainThreadOnly { 365 struct MainThreadOnly {
355 MainThreadOnly(const scoped_refptr<TaskQueue>& compositor_task_runner, 366 MainThreadOnly(RendererSchedulerImpl* renderer_scheduler_impl,
367 const scoped_refptr<TaskQueue>& compositor_task_runner,
356 base::TickClock* time_source); 368 base::TickClock* time_source);
357 ~MainThreadOnly(); 369 ~MainThreadOnly();
358 370
359 TaskCostEstimator loading_task_cost_estimator; 371 TaskCostEstimator loading_task_cost_estimator;
360 TaskCostEstimator timer_task_cost_estimator; 372 TaskCostEstimator timer_task_cost_estimator;
373 QueueingTimeEstimator queueing_time_estimator;
361 IdleTimeEstimator idle_time_estimator; 374 IdleTimeEstimator idle_time_estimator;
362 UseCase current_use_case; 375 UseCase current_use_case;
363 Policy current_policy; 376 Policy current_policy;
364 base::TimeTicks current_policy_expiration_time; 377 base::TimeTicks current_policy_expiration_time;
365 base::TimeTicks estimated_next_frame_begin; 378 base::TimeTicks estimated_next_frame_begin;
366 base::TimeDelta compositor_frame_interval; 379 base::TimeDelta compositor_frame_interval;
367 base::TimeDelta longest_jank_free_task_duration; 380 base::TimeDelta longest_jank_free_task_duration;
368 int timer_queue_suspend_count; // TIMER_TASK_QUEUE suspended if non-zero. 381 int timer_queue_suspend_count; // TIMER_TASK_QUEUE suspended if non-zero.
369 int navigation_task_expected_count; 382 int navigation_task_expected_count;
370 ExpensiveTaskPolicy expensive_task_policy; 383 ExpensiveTaskPolicy expensive_task_policy;
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
454 467
455 PollableThreadSafeFlag policy_may_need_update_; 468 PollableThreadSafeFlag policy_may_need_update_;
456 base::WeakPtrFactory<RendererSchedulerImpl> weak_factory_; 469 base::WeakPtrFactory<RendererSchedulerImpl> weak_factory_;
457 470
458 DISALLOW_COPY_AND_ASSIGN(RendererSchedulerImpl); 471 DISALLOW_COPY_AND_ASSIGN(RendererSchedulerImpl);
459 }; 472 };
460 473
461 } // namespace scheduler 474 } // namespace scheduler
462 475
463 #endif // COMPONENTS_SCHEDULER_RENDERER_RENDERER_SCHEDULER_IMPL_H_ 476 #endif // COMPONENTS_SCHEDULER_RENDERER_RENDERER_SCHEDULER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698