Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1898213002: Reland of [NTP Snippets] Refresh the displayed snippets less frequently (Closed)

Created:
4 years, 8 months ago by dgn
Modified:
4 years, 8 months ago
CC:
chromium-reviews, dgn+watch_chromium.org, mcwilliams+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Refresh the displayed snippets less frequently Relanding the change that was reverted in https://codereview.chromium.org/1897313002 Original issue's description: > The fetch frequence of the snippet service does not change, but the > snippets are now refreshed less frequently on the UI. They are pulled > when the NTP is opened, or when the user switches back to it from > another tab or another app. > > Additionally, we also change the way the list is updated, adding only > new entries instead of clearing the old list and replacing it with > the new one. BUG=601757, 604763 TBR=bauerb@chromium.org Committed: https://crrev.com/cb0b829783d26fe083f951a58c2395bef0f06840 Cr-Commit-Position: refs/heads/master@{#388235}

Patch Set 1 #

Patch Set 2 : fix test issue #

Messages

Total messages: 9 (4 generated)
dgn
Created Reland of [NTP Snippets] Refresh the displayed snippets less frequently
4 years, 8 months ago (2016-04-19 16:37:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898213002/190001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898213002/190001
4 years, 8 months ago (2016-04-19 17:03:57 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:190001)
4 years, 8 months ago (2016-04-19 17:35:14 UTC) #6
Bernhard Bauer
lgtm
4 years, 8 months ago (2016-04-20 08:16:00 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:13:25 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cb0b829783d26fe083f951a58c2395bef0f06840
Cr-Commit-Position: refs/heads/master@{#388235}

Powered by Google App Engine
This is Rietveld 408576698