Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1897313002: Revert of [NTP Snippets] Refresh the displayed snippets less frequently (Closed)

Created:
4 years, 8 months ago by cmumford
Modified:
4 years, 8 months ago
CC:
chromium-reviews, mcwilliams+watch_chromium.org, dgn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [NTP Snippets] Refresh the displayed snippets less frequently (patchset #7 id:120001 of https://codereview.chromium.org/1888913002/ ) Reason for revert: testSnippetLoading is failing. Opened new bug: crbug.com/604763 Original issue's description: > [NTP Snippets] Refresh the displayed snippets less frequently > > The fetch frequence of the snippet service does not change, but the > snippets are now refreshed less frequently on the UI. They are pulled > when the NTP is opened, or when the user switches back to it from > another tab or another app. > > Additionally, we also change the way the list is updated, adding only > new entries instead of clearing the old list and replacing it with > the new one. > > BUG=601757 > > Committed: https://crrev.com/104124354787e845e02db283185d499232518dd6 > Cr-Commit-Position: refs/heads/master@{#388195} TBR=treib@chromium.org,bauerb@chromium.org,dgn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=601757 Committed: https://crrev.com/71a6f5091c48bb552b63613b8666a4b4ac6dcc7d Cr-Commit-Position: refs/heads/master@{#388218}

Patch Set 1 #

Messages

Total messages: 6 (1 generated)
cmumford
Created Revert of [NTP Snippets] Refresh the displayed snippets less frequently
4 years, 8 months ago (2016-04-19 16:22:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897313002/1
4 years, 8 months ago (2016-04-19 16:23:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 16:23:44 UTC) #3
dgn
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1898213002/ by dgn@chromium.org. ...
4 years, 8 months ago (2016-04-19 16:37:26 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:12:40 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71a6f5091c48bb552b63613b8666a4b4ac6dcc7d
Cr-Commit-Position: refs/heads/master@{#388218}

Powered by Google App Engine
This is Rietveld 408576698