Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1898193005: add SK_SUPPORT_LEGACY_IMAGEFILTER_CTM for future skia cl (Closed)

Created:
4 years, 8 months ago by reed1
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add SK_SUPPORT_LEGACY_IMAGEFILTER_CTM for future skia cl in support of this CL https://codereview.chromium.org/1899263002/ Note: there is a related flag with a different name already in blink, which controls whether blink also tries to handle affine ctms and filters. I think that is somewhat orthogonal, as this new flag controls what skia does by default, and for rebaselining we may want to change these flags separately (or not). See https://codereview.chromium.org/1205413003 BUG= Committed: https://crrev.com/dafbff4e06b16d2005b0bdc077e5ea7f2642237a Cr-Commit-Position: refs/heads/master@{#388309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
reed1
4 years, 8 months ago (2016-04-19 20:02:48 UTC) #3
Stephen White
LGTM
4 years, 8 months ago (2016-04-19 20:03:26 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898193005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898193005/1
4 years, 8 months ago (2016-04-19 20:03:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898193005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898193005/1
4 years, 8 months ago (2016-04-19 20:09:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 21:13:11 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:16:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dafbff4e06b16d2005b0bdc077e5ea7f2642237a
Cr-Commit-Position: refs/heads/master@{#388309}

Powered by Google App Engine
This is Rietveld 408576698