Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: net/socket/websocket_transport_client_socket_pool.cc

Issue 1898133002: Add reprioritization to socket pools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated latest round of comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/websocket_transport_client_socket_pool.cc
diff --git a/net/socket/websocket_transport_client_socket_pool.cc b/net/socket/websocket_transport_client_socket_pool.cc
index 0239226da9910a94aea263729e8da7bbcad538f9..05ee439d36fa21e4c68a15db5e7e9f4971ee62e9 100644
--- a/net/socket/websocket_transport_client_socket_pool.cc
+++ b/net/socket/websocket_transport_client_socket_pool.cc
@@ -392,6 +392,16 @@ void WebSocketTransportClientSocketPool::RequestSockets(
NOTIMPLEMENTED();
}
+void WebSocketTransportClientSocketPool::SetPriority(
+ const std::string& group_name,
+ ClientSocketHandle* handle,
+ RequestPriority priority) {
+ // Since sockets requested by RequestSocket are bound early, there's
+ // nothing to do within the pool to change priority or the request.
+ // TODO(rdsmith): Investigate plumbing the reprioritization request to the
+ // connect job.
mmenke 2017/01/18 20:37:27 What if it's in stalled_request_map_?
Randy Smith (Not in Mondays) 2017/01/22 21:37:00 Hmmm. Good point, I missed that. However, stalle
Adam Rice 2017/01/23 02:26:34 All WebSocket handshakes happen at DEFAULT_PRIORIT
+}
+
void WebSocketTransportClientSocketPool::CancelRequest(
const std::string& group_name,
ClientSocketHandle* handle) {

Powered by Google App Engine
This is Rietveld 408576698