Add reprioritization to socket pools.

net/socket/websocket_transport_client_socket_pool.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/websocket_transport_client_socket_pool.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/compiler_specific.h"
@@ skipping 374 matching lines @@
 }
 
 void WebSocketTransportClientSocketPool::RequestSockets(
     const std::string& group_name,
     const void* params,
     int num_sockets,
     const NetLogWithSource& net_log) {
   NOTIMPLEMENTED();
 }
 
+void WebSocketTransportClientSocketPool::SetPriority(
+    const std::string& group_name,
+    ClientSocketHandle* handle,
+    RequestPriority priority) {
+  // Since sockets requested by RequestSocket are bound early, there's
+  // nothing to do within the pool to change priority or the request.
+  // TODO(rdsmith): Investigate plumbing the reprioritization request to the
+  // connect job.

[mmenke, 2017/01/18 20:37:27]

What if it's in stalled_request_map_?

[Randy Smith (Not in Mondays), 2017/01/22 21:37:00]

Hmmm.  Good point, I missed that.

However, stalled_request_map_ is blissfully priority unaware, even of the
priority that request carries when it comes in, AFAICT.  So making SetPriority()
have any effect would almost force stalled_request_map_ over to being a priority
queue, which would be a functional change to WebSockets, which I'm a bit
reluctant to do?

Adam, was this intentional?  Are you positive, neutral, or negative about
changing stalled_request_map_ to know about priorities?  (Not promising to do it
if you're positive, just trying to understand the lay of the land.)

[Adam Rice, 2017/01/23 02:26:34]

All WebSocket handshakes happen at DEFAULT_PRIORITY, so supporting SetPriority
correctly for WebSocket would be pointless. Unless it makes the code simpler,
ignoring priorities is the best option.

+}
+
 void WebSocketTransportClientSocketPool::CancelRequest(
     const std::string& group_name,
     ClientSocketHandle* handle) {
   DCHECK(!handle->is_initialized());
   if (DeleteStalledRequest(handle))
     return;
   std::unique_ptr<StreamSocket> socket = handle->PassSocket();
   if (socket)
     ReleaseSocket(handle->group_name(), std::move(socket), handle->id());
   if (!DeleteJob(handle))
@@ skipping 292 matching lines @@
       handle(handle),
       callback(callback),
       net_log(net_log) {}
 
 WebSocketTransportClientSocketPool::StalledRequest::StalledRequest(
     const StalledRequest& other) = default;
 
 WebSocketTransportClientSocketPool::StalledRequest::~StalledRequest() {}
 
 }  // namespace net