Issue 1898113002: No SelectFilePolicy for password import and export UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1898113002: No SelectFilePolicy for password import and export UI (Closed)

Created:
4 years, 8 months ago by vabr (Chromium)

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews, dbeam+watch-options_chromium.org, gcasto+watchlist_chromium.org, michaelpg+watch-options_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@341477_about_flags

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

No SelectFilePolicy for password import and export UI Remove the leaked policy in the code and replace it with a nullptr. The policy did not specify anything special and hence was not needed. BUG=341477

Patch Set 1 #

Patch Set 2 : Remove unused #include #

Patch Set 3 : Also no policy for export #

Patch Set 4 : Remove leak suppresion #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -15 lines)			Patch
	M	chrome/browser/ui/webui/options/password_manager_handler.cc	View	1 2	3 chunks	+2 lines, -9 lines	0 comments	Download
	M	tools/valgrind/memcheck/suppressions.txt	View	1 2 3	1 chunk	+0 lines, -6 lines	0 comments	Download

Depends on Patchset:

Issue 1900063002 Patch 1

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vabr (Chromium)

4 years, 8 months ago (2016-04-19 12:39:15 UTC) #2

Message was sent while issue was closed.

Closed without landing, because (1) the chrome-specific policy should be used
after all (handles Chrome shutdown properly), and (2) the issue with the leak
was because of the test. https://codereview.chromium.org/1898143002 has the
correct fix.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages