Properly delete the unused policy in password_manager_handler_unittest.cc

Properly delete the unused policy in password_manager_handler_unittest.cc

ui::SelectFilePolicy* passed to the SelectFileDialog creation methods are
assumed to be owned by the callee (they should ultimately end up in
SelectFileDialog::select_file_policy_, which is a unique_ptr). However,
the test factory in password_manager_handler_unittest.cc ignores the policy
it gets without deleting it. This CL deletes the ignored policy and removes
the leak annotations.

BUG=341477
Committed: https://crrev.com/fcbfda57b74a524deb20aa9a2124ce75470eb39f
Cr-Commit-Position: refs/heads/master@{#388458}

[vabr (Chromium), 2016-04-19 15:37:56]

vabr@chromium.org changed reviewers:
+ dbeam@chromium.org

[vabr (Chromium), 2016-04-19 15:37:57]

Hi Dan,

Could you please take a look?

Thanks,
Vaclav

[vabr (Chromium), 2016-04-19 15:38:05]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 15:38:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1898143002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1898143002/1

[vabr (Chromium), 2016-04-19 15:38:57]

Description was changed from

==========
Properly delete the unused policy in password_manager_handler_unittest.cc

ui::SelectFilePolicy* passed to the SelectFileDialog creation methods are
assumed to be owned by the callee (they should ultimately end up in
SelectFileDialog::select_file_policy_). However, the test factory in
password_manager_handler_unittest.cc ignores the policy it gets without
deleting it. This CL deletes the ignored policy and removes the leak
annotations.

BUG=341477

Remove leak suppresion
==========

to

==========
Properly delete the unused policy in password_manager_handler_unittest.cc

ui::SelectFilePolicy* passed to the SelectFileDialog creation methods are
assumed to be owned by the callee (they should ultimately end up in
SelectFileDialog::select_file_policy_, which is a unique_ptr). However,
the test factory in password_manager_handler_unittest.cc ignores the policy
it gets without deleting it. This CL deletes the ignored policy and removes
the leak annotations.

BUG=341477
==========

[commit-bot: I haz the power, 2016-04-19 16:12:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 16:12:28]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-04-19 17:31:28]

heh, sneaky

lgtm

[vabr (Chromium), 2016-04-20 09:43:40]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-04-20 09:43:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1898143002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1898143002/1

[commit-bot: I haz the power, 2016-04-20 09:47:31]

Description was changed from

==========
Properly delete the unused policy in password_manager_handler_unittest.cc

ui::SelectFilePolicy* passed to the SelectFileDialog creation methods are
assumed to be owned by the callee (they should ultimately end up in
SelectFileDialog::select_file_policy_, which is a unique_ptr). However,
the test factory in password_manager_handler_unittest.cc ignores the policy
it gets without deleting it. This CL deletes the ignored policy and removes
the leak annotations.

BUG=341477
==========

to

==========
Properly delete the unused policy in password_manager_handler_unittest.cc

ui::SelectFilePolicy* passed to the SelectFileDialog creation methods are
assumed to be owned by the callee (they should ultimately end up in
SelectFileDialog::select_file_policy_, which is a unique_ptr). However,
the test factory in password_manager_handler_unittest.cc ignores the policy
it gets without deleting it. This CL deletes the ignored policy and removes
the leak annotations.

BUG=341477
==========

[commit-bot: I haz the power, 2016-04-20 09:47:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-22 19:22:05]

Description was changed from

==========
Properly delete the unused policy in password_manager_handler_unittest.cc

ui::SelectFilePolicy* passed to the SelectFileDialog creation methods are
assumed to be owned by the callee (they should ultimately end up in
SelectFileDialog::select_file_policy_, which is a unique_ptr). However,
the test factory in password_manager_handler_unittest.cc ignores the policy
it gets without deleting it. This CL deletes the ignored policy and removes
the leak annotations.

BUG=341477
==========

to

==========
Properly delete the unused policy in password_manager_handler_unittest.cc

ui::SelectFilePolicy* passed to the SelectFileDialog creation methods are
assumed to be owned by the callee (they should ultimately end up in
SelectFileDialog::select_file_policy_, which is a unique_ptr). However,
the test factory in password_manager_handler_unittest.cc ignores the policy
it gets without deleting it. This CL deletes the ignored policy and removes
the leak annotations.

BUG=341477

Committed: https://crrev.com/fcbfda57b74a524deb20aa9a2124ce75470eb39f
Cr-Commit-Position: refs/heads/master@{#388458}
==========

[commit-bot: I haz the power, 2016-04-22 19:22:06]

Patchset 1 (id:??) landed as
https://crrev.com/fcbfda57b74a524deb20aa9a2124ce75470eb39f
Cr-Commit-Position: refs/heads/master@{#388458}