Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1898043003: Check Android API level when using usb.UsbDevice.getManufacturerName (Closed)

Created:
4 years, 8 months ago by juncai
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check Android API level when using usb.UsbDevice.getManufacturerName android.hardware.usb.UsbDevice.getManufacturerName was added in API level 21. This patch added code to check the API level to avoid java.lang.NoSuchMethodError when testing pervious Android versions. BUG=604634 Committed: https://crrev.com/36d86338ea22decaa3a91eceb9a3dfdfbca2d40e Cr-Commit-Position: refs/heads/master@{#388294}

Patch Set 1 : check Android API level when using usb.UsbDevice.getManufacturerName #

Patch Set 2 : check Android API level when using getProductName and getSerialNumber #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M device/usb/usb_device_android.cc View 1 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
juncai
Please take a look.
4 years, 8 months ago (2016-04-19 18:54:47 UTC) #2
Reilly Grant (use Gerrit)
lgtm
4 years, 8 months ago (2016-04-19 19:05:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898043003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898043003/20001
4 years, 8 months ago (2016-04-19 19:15:43 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-19 20:19:12 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:15:44 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/36d86338ea22decaa3a91eceb9a3dfdfbca2d40e
Cr-Commit-Position: refs/heads/master@{#388294}

Powered by Google App Engine
This is Rietveld 408576698