Check Android API level when using usb.UsbDevice.getManufacturerName

device/usb/usb_device_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/usb/usb_device_android.h"
 
 #include "base/android/build_info.h"
 #include "base/android/jni_string.h"
 #include "base/bind.h"
 #include "base/location.h"
@@ skipping 17 matching lines @@
 
 // static
 scoped_refptr<UsbDeviceAndroid> UsbDeviceAndroid::Create(
     JNIEnv* env,
     const JavaRef<jobject>& usb_device) {
   ScopedJavaLocalRef<jobject> wrapper =
       Java_ChromeUsbDevice_create(env, usb_device.obj());
   uint16_t device_version = 0;
   if (base::android::BuildInfo::GetInstance()->sdk_int() >= 23)
     device_version = Java_ChromeUsbDevice_getDeviceVersion(env, wrapper.obj());
-  ScopedJavaLocalRef<jstring> manufacturer_string =
-      Java_ChromeUsbDevice_getManufacturerName(env, wrapper.obj());
-  ScopedJavaLocalRef<jstring> product_string =
-      Java_ChromeUsbDevice_getProductName(env, wrapper.obj());
-  ScopedJavaLocalRef<jstring> serial_number =
-      Java_ChromeUsbDevice_getSerialNumber(env, wrapper.obj());
+  base::string16 manufacturer_string, product_string, serial_number;
+  if (base::android::BuildInfo::GetInstance()->sdk_int() >= 21) {
+    manufacturer_string = ConvertJavaStringToUTF16(
+        env, Java_ChromeUsbDevice_getManufacturerName(env, wrapper.obj()));
+    product_string = ConvertJavaStringToUTF16(
+        env, Java_ChromeUsbDevice_getProductName(env, wrapper.obj()));
+    serial_number = ConvertJavaStringToUTF16(
+        env, Java_ChromeUsbDevice_getSerialNumber(env, wrapper.obj()));
+  }
   return make_scoped_refptr(new UsbDeviceAndroid(
       env,
       0x0200,  // USB protocol version, not provided by the Android API.
       Java_ChromeUsbDevice_getDeviceClass(env, wrapper.obj()),
       Java_ChromeUsbDevice_getDeviceSubclass(env, wrapper.obj()),
       Java_ChromeUsbDevice_getDeviceProtocol(env, wrapper.obj()),
       Java_ChromeUsbDevice_getVendorId(env, wrapper.obj()),
       Java_ChromeUsbDevice_getProductId(env, wrapper.obj()), device_version,
-      ConvertJavaStringToUTF16(env, manufacturer_string),
-      ConvertJavaStringToUTF16(env, product_string),
-      ConvertJavaStringToUTF16(env, serial_number), wrapper));
+      manufacturer_string, product_string, serial_number, wrapper));
 }
 
 void UsbDeviceAndroid::Open(const OpenCallback& callback) {
   base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
                                                 base::Bind(callback, nullptr));
 }
 
 const UsbConfigDescriptor* UsbDeviceAndroid::GetActiveConfiguration() const {
   return nullptr;
 }
@@ skipping 49 matching lines @@
           env, env->GetObjectArrayElement(interfaces.obj(), i));
       config.interfaces.push_back(UsbInterfaceAndroid::Convert(env, interface));
     }
     configurations_.push_back(config);
   }
 }
 
 UsbDeviceAndroid::~UsbDeviceAndroid() {}
 
 }  // namespace device