DNS: Add stubs for persisting data across restarts

DNS: Add stubs for persisting data across restarts

I'm going to start experimenting with making certain data in the DNS
stack (cache, learned RTT, etc.) persist across restarts or network
type changes (e.g. on 2G -> 3G -> 2G, restore the previous 2G RTT
instead of starting over).

This CL adds the basic set of methods that will be called, but does not
add the code to include anything in the persisted data, nor the code to
actually persist the data outside the DNS stack.

BUG=605149
Committed: https://crrev.com/d7fa5853a258f273864bd53dfbb9bb3c52e6dd1f
Cr-Commit-Position: refs/heads/master@{#408624}

[Julia Tuttle, 2016-07-22 20:19:09]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 20:19:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 20:28:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 20:28:41]

Dry run: Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[Julia Tuttle, 2016-07-25 19:54:17]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[Julia Tuttle, 2016-07-25 19:54:31]

Description was changed from

==========
WIP: DNS: Add stubs for persisting data across restarts

I'm going to start experimenting with making certain data in the DNS
stack (cache, learned RTT, etc.) persist across restarts or network
type changes (e.g. on 2G -> 3G -> 2G, restore the previous 2G RTT
instead of starting over).

This CL adds the basic set of methods that will be called, but does not
add the code to include anything in the persisted data, nor the code to
actually persist the data outside the DNS stack.

BUG=605149
==========

to

==========
DNS: Add stubs for persisting data across restarts

I'm going to start experimenting with making certain data in the DNS
stack (cache, learned RTT, etc.) persist across restarts or network
type changes (e.g. on 2G -> 3G -> 2G, restore the previous 2G RTT
instead of starting over).

This CL adds the basic set of methods that will be called, but does not
add the code to include anything in the persisted data, nor the code to
actually persist the data outside the DNS stack.

BUG=605149
==========

[Julia Tuttle, 2016-07-25 19:54:46]

juliatuttle@chromium.org changed reviewers:
+ csharrison@chromium.org

[commit-bot: I haz the power, 2016-07-25 19:54:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Julia Tuttle, 2016-07-25 19:54:46]

PTAL, csharrison.

[commit-bot: I haz the power, 2016-07-25 20:03:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 20:03:07]

Dry run: Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[Charlie Harrison, 2016-07-26 13:49:42]

Can you explain a bit why you need a persist callback?

https://codereview.chromium.org/1898033006/diff/60001/net/dns/dns_client.cc
File net/dns/dns_client.cc (right):

https://codereview.chromium.org/1898033006/diff/60001/net/dns/dns_client.cc#n...
net/dns/dns_client.cc:24: #if !defined(OS_IOS)
Why is this necessary?

https://codereview.chromium.org/1898033006/diff/60001/net/dns/host_resolver.cc
File net/dns/host_resolver.cc (right):

https://codereview.chromium.org/1898033006/diff/60001/net/dns/host_resolver.c...
net/dns/host_resolver.cc:120: void HostResolver::InitializePersistence(
Can you document this?

https://codereview.chromium.org/1898033006/diff/60001/net/dns/host_resolver_i...
File net/dns/host_resolver_impl.cc (right):

https://codereview.chromium.org/1898033006/diff/60001/net/dns/host_resolver_i...
net/dns/host_resolver_impl.cc:1906: void
HostResolverImpl::SetDnsClient(std::unique_ptr<DnsClient> dns_client) {
Did this need to move?

[Julia Tuttle, 2016-07-26 19:08:46]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 19:09:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 19:16:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 19:16:43]

Dry run: Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[Julia Tuttle, 2016-07-26 19:18:21]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 19:18:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 19:25:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 19:25:38]

Dry run: Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[Julia Tuttle, 2016-07-26 19:46:22]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 19:46:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Julia Tuttle, 2016-07-26 21:10:14]

PTAL, csharrison.

https://codereview.chromium.org/1898033006/diff/60001/net/dns/dns_client.cc
File net/dns/dns_client.cc (right):

https://codereview.chromium.org/1898033006/diff/60001/net/dns/dns_client.cc#n...
net/dns/dns_client.cc:24: #if !defined(OS_IOS)
On 2016/07/26 13:49:42, csharrison wrote:
> Why is this necessary?

It's not! Fixed.

https://codereview.chromium.org/1898033006/diff/60001/net/dns/host_resolver.cc
File net/dns/host_resolver.cc (right):

https://codereview.chromium.org/1898033006/diff/60001/net/dns/host_resolver.c...
net/dns/host_resolver.cc:120: void HostResolver::InitializePersistence(
On 2016/07/26 13:49:42, csharrison wrote:
> Can you document this?

Done.

https://codereview.chromium.org/1898033006/diff/60001/net/dns/host_resolver_i...
File net/dns/host_resolver_impl.cc (right):

https://codereview.chromium.org/1898033006/diff/60001/net/dns/host_resolver_i...
net/dns/host_resolver_impl.cc:1906: void
HostResolverImpl::SetDnsClient(std::unique_ptr<DnsClient> dns_client) {
On 2016/07/26 13:49:42, csharrison wrote:
> Did this need to move?

Nope.

[commit-bot: I haz the power, 2016-07-26 21:22:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 21:22:51]

Dry run: This issue passed the CQ dry run.

[Charlie Harrison, 2016-07-27 17:59:47]

lgtm with a question

https://codereview.chromium.org/1898033006/diff/120001/net/net_common.gypi
File net/net_common.gypi (left):

https://codereview.chromium.org/1898033006/diff/120001/net/net_common.gypi#ol...
net/net_common.gypi:108: 'dns/dns_client.cc',
Is this a tangential fix?

[Julia Tuttle, 2016-07-28 19:46:25]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 19:46:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Julia Tuttle, 2016-07-28 19:48:01]

It was part of the iOS fiddling that I reverted. Let's find out if I need it.

https://codereview.chromium.org/1898033006/diff/120001/net/net_common.gypi
File net/net_common.gypi (left):

https://codereview.chromium.org/1898033006/diff/120001/net/net_common.gypi#ol...
net/net_common.gypi:108: 'dns/dns_client.cc',
On 2016/07/27 17:59:47, csharrison wrote:
> Is this a tangential fix?

Leftover from the weird iOS fiddling I did before. Testing without it.

[commit-bot: I haz the power, 2016-07-28 20:57:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 20:57:26]

Dry run: This issue passed the CQ dry run.

[Julia Tuttle, 2016-07-28 21:58:38]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 21:59:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 23:10:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 23:11:00]

Dry run: This issue passed the CQ dry run.

[Julia Tuttle, 2016-07-29 13:13:30]

The CQ bit was checked by juliatuttle@chromium.org

[Julia Tuttle, 2016-07-29 13:13:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
csharrison@chromium.org
Link to the patchset: https://codereview.chromium.org/1898033006/#ps160001
(title: "*silently glares at editor, reuploads with proper spacing*")

[commit-bot: I haz the power, 2016-07-29 13:13:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 13:17:12]

Description was changed from

==========
DNS: Add stubs for persisting data across restarts

I'm going to start experimenting with making certain data in the DNS
stack (cache, learned RTT, etc.) persist across restarts or network
type changes (e.g. on 2G -> 3G -> 2G, restore the previous 2G RTT
instead of starting over).

This CL adds the basic set of methods that will be called, but does not
add the code to include anything in the persisted data, nor the code to
actually persist the data outside the DNS stack.

BUG=605149
==========

to

==========
DNS: Add stubs for persisting data across restarts

I'm going to start experimenting with making certain data in the DNS
stack (cache, learned RTT, etc.) persist across restarts or network
type changes (e.g. on 2G -> 3G -> 2G, restore the previous 2G RTT
instead of starting over).

This CL adds the basic set of methods that will be called, but does not
add the code to include anything in the persisted data, nor the code to
actually persist the data outside the DNS stack.

BUG=605149
==========

[commit-bot: I haz the power, 2016-07-29 13:17:12]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-07-29 13:18:25]

Description was changed from

==========
DNS: Add stubs for persisting data across restarts

I'm going to start experimenting with making certain data in the DNS
stack (cache, learned RTT, etc.) persist across restarts or network
type changes (e.g. on 2G -> 3G -> 2G, restore the previous 2G RTT
instead of starting over).

This CL adds the basic set of methods that will be called, but does not
add the code to include anything in the persisted data, nor the code to
actually persist the data outside the DNS stack.

BUG=605149
==========

to

==========
DNS: Add stubs for persisting data across restarts

I'm going to start experimenting with making certain data in the DNS
stack (cache, learned RTT, etc.) persist across restarts or network
type changes (e.g. on 2G -> 3G -> 2G, restore the previous 2G RTT
instead of starting over).

This CL adds the basic set of methods that will be called, but does not
add the code to include anything in the persisted data, nor the code to
actually persist the data outside the DNS stack.

BUG=605149

Committed: https://crrev.com/d7fa5853a258f273864bd53dfbb9bb3c52e6dd1f
Cr-Commit-Position: refs/heads/master@{#408624}
==========

[commit-bot: I haz the power, 2016-07-29 13:18:26]

Patchset 9 (id:??) landed as
https://crrev.com/d7fa5853a258f273864bd53dfbb9bb3c52e6dd1f
Cr-Commit-Position: refs/heads/master@{#408624}