DNS: Add stubs for persisting data across restarts

net/dns/dns_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/dns/dns_client.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
 #include "base/rand_util.h"
 #include "net/dns/address_sorter.h"
 #include "net/dns/dns_config_service.h"
 #include "net/dns/dns_session.h"
 #include "net/dns/dns_socket_pool.h"
 #include "net/dns/dns_transaction.h"
 #include "net/log/net_log.h"
 #include "net/socket/client_socket_factory.h"
 
 namespace net {
 
 namespace {
 
+#if !defined(OS_IOS)

[Charlie Harrison, 2016/07/26 13:49:42]

Why is this necessary?

[Julia Tuttle, 2016/07/26 21:10:13]

It's not! Fixed.

 class DnsClientImpl : public DnsClient {
  public:
   DnsClientImpl(NetLog* net_log,
                 ClientSocketFactory* socket_factory,
                 const RandIntCallback& rand_int_callback)
       : address_sorter_(AddressSorter::CreateAddressSorter()),
         net_log_(net_log),
         socket_factory_(socket_factory),
         rand_int_callback_(rand_int_callback) {}
 
@@ skipping 15 matching lines @@
   const DnsConfig* GetConfig() const override {
     return session_.get() ? &session_->config() : NULL;
   }
 
   DnsTransactionFactory* GetTransactionFactory() override {
     return session_.get() ? factory_.get() : NULL;
   }
 
   AddressSorter* GetAddressSorter() override { return address_sorter_.get(); }
 
+  std::unique_ptr<const base::Value> GetPersistentData() const override {
+    if (!session_)
+      return std::unique_ptr<const base::Value>();
+    return session_->GetPersistentData();
+  }
+
+  void ApplyPersistentData(const base::Value& data) override {
+    if (!session_)
+      return;
+    session_->ApplyPersistentData(data);
+  }
+
  private:
   scoped_refptr<DnsSession> session_;
   std::unique_ptr<DnsTransactionFactory> factory_;
   std::unique_ptr<AddressSorter> address_sorter_;
 
   NetLog* net_log_;
 
   ClientSocketFactory* socket_factory_;
   const RandIntCallback rand_int_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(DnsClientImpl);
 };
+#endif  // !defined(OS_IOS)
 
 }  // namespace
 
+void DnsClient::ApplyPersistentData(const base::Value& data) {}
+
+std::unique_ptr<const base::Value> DnsClient::GetPersistentData() const {
+  return std::unique_ptr<const base::Value>();
+}
+
 // static
 std::unique_ptr<DnsClient> DnsClient::CreateClient(NetLog* net_log) {
+#if !defined(OS_IOS)
   return base::WrapUnique(
       new DnsClientImpl(net_log, ClientSocketFactory::GetDefaultFactory(),
                         base::Bind(&base::RandInt)));
+#else   // defined(OS_IOS)
+  NOTIMPLEMENTED();
+  return std::unique_ptr<DnsClient>(nullptr);
+#endif  // defined(OS_IOS)
 }
 
 // static
 std::unique_ptr<DnsClient> DnsClient::CreateClientForTesting(
     NetLog* net_log,
     ClientSocketFactory* socket_factory,
     const RandIntCallback& rand_int_callback) {
+#if !defined(OS_IOS)
   return base::WrapUnique(
       new DnsClientImpl(net_log, socket_factory, rand_int_callback));
+#else   // defined(OS_IOS)
+  NOTIMPLEMENTED();
+  return std::unique_ptr<DnsClient>(nullptr);
+#endif  // defined(OS_IOS)
 }
 
 }  // namespace net