Use gpu::SharedMemoryLimits for in process GL contexts.

Use gpu::SharedMemoryLimits for in process GL contexts.

Replace the GLInProcessContextSharedMemoryLimits class with our new
SharedMemoryLimits class, so we can share implementations and defaults.

R=boliu@chromium.org, piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/f3cd380618d431d1c29a12e03989f3657bec5228
Cr-Commit-Position: refs/heads/master@{#388633}

[danakj, 2016-04-20 02:05:12]

Description was changed from

==========
Use gpu::SharedMemoryLimits for in process GL contexts.

Replace the GLInProcessContextSharedMemoryLimits class with our new
SharedMemoryLimits class, so we can share implementations and defaults.

R=boliu@chromium.org, piman@chromium.org
BUG=584497
==========

to

==========
Use gpu::SharedMemoryLimits for in process GL contexts.

Replace the GLInProcessContextSharedMemoryLimits class with our new
SharedMemoryLimits class, so we can share implementations and defaults.

R=boliu@chromium.org, piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[danakj, 2016-04-20 02:05:13]

Description was changed from

==========
Use gpu::SharedMemoryLimits for in process GL contexts.

Replace the GLInProcessContextSharedMemoryLimits class with our new
SharedMemoryLimits class, so we can share implementations and defaults.

R=boliu@chromium.org, piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Use gpu::SharedMemoryLimits for in process GL contexts.

Replace the GLInProcessContextSharedMemoryLimits class with our new
SharedMemoryLimits class, so we can share implementations and defaults.

R=boliu@chromium.org, piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[danakj, 2016-04-20 02:13:24]

danakj@chromium.org changed reviewers:
+ nyquist@chromium.org

[danakj, 2016-04-20 02:13:53]

https://codereview.chromium.org/1898033005/diff/20001/android_webview/browser...
File android_webview/browser/aw_render_thread_context_provider.cc (right):

https://codereview.chromium.org/1898033005/diff/20001/android_webview/browser...
android_webview/browser/aw_render_thread_context_provider.cc:57:
limits.start_transfer_buffer_size = 4 * 1024 * 1024;
I took this from the old defaults which were different from the ones that were
in WebGraphicsContext3DCommandBufferImpl, for some reason?

[danakj, 2016-04-20 02:14:12]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 02:14:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1898033005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1898033005/20001

[commit-bot: I haz the power, 2016-04-20 02:24:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 02:24:27]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[boliu, 2016-04-20 02:39:23]

https://codereview.chromium.org/1898033005/diff/20001/android_webview/browser...
File android_webview/browser/aw_render_thread_context_provider.cc (right):

https://codereview.chromium.org/1898033005/diff/20001/android_webview/browser...
android_webview/browser/aw_render_thread_context_provider.cc:57:
limits.start_transfer_buffer_size = 4 * 1024 * 1024;
On 2016/04/20 02:13:53, danakj wrote:
> I took this from the old defaults which were different from the ones that were
> in WebGraphicsContext3DCommandBufferImpl, for some reason?

This only runs the delegated compositor, which is draw quads only, and no
upload, right? Can we save some memory by lowering this to like something tiny?
That'd be great :p

[piman, 2016-04-20 21:02:11]

lgtm

[nyquist, 2016-04-20 21:15:49]

blimp lgtm

[danakj, 2016-04-20 21:55:02]

PTAL bo

https://codereview.chromium.org/1898033005/diff/20001/android_webview/browser...
File android_webview/browser/aw_render_thread_context_provider.cc (right):

https://codereview.chromium.org/1898033005/diff/20001/android_webview/browser...
android_webview/browser/aw_render_thread_context_provider.cc:57:
limits.start_transfer_buffer_size = 4 * 1024 * 1024;
On 2016/04/20 02:39:23, boliu wrote:
> On 2016/04/20 02:13:53, danakj wrote:
> > I took this from the old defaults which were different from the ones that
were
> > in WebGraphicsContext3DCommandBufferImpl, for some reason?
> 
> This only runs the delegated compositor, which is draw quads only, and no
> upload, right? Can we save some memory by lowering this to like something
tiny?
> That'd be great :p

Stealing from compositor_impl_android then.

[danakj, 2016-04-20 21:55:11]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 21:55:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1898033005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1898033005/40001

[boliu, 2016-04-20 22:11:49]

lgtm

[danakj, 2016-04-20 22:12:41]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-04-20 22:12:44]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-04-20 22:12:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
nyquist@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1898033005/#ps40001
(title: "inproc-limits: webviewlimits")

[commit-bot: I haz the power, 2016-04-20 22:13:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1898033005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1898033005/40001

[commit-bot: I haz the power, 2016-04-21 00:28:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:28:51]

Description was changed from

==========
Use gpu::SharedMemoryLimits for in process GL contexts.

Replace the GLInProcessContextSharedMemoryLimits class with our new
SharedMemoryLimits class, so we can share implementations and defaults.

R=boliu@chromium.org, piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Use gpu::SharedMemoryLimits for in process GL contexts.

Replace the GLInProcessContextSharedMemoryLimits class with our new
SharedMemoryLimits class, so we can share implementations and defaults.

R=boliu@chromium.org, piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/f3cd380618d431d1c29a12e03989f3657bec5228
Cr-Commit-Position: refs/heads/master@{#388633}
==========

[commit-bot: I haz the power, 2016-04-22 19:28:52]

Patchset 3 (id:??) landed as
https://crrev.com/f3cd380618d431d1c29a12e03989f3657bec5228
Cr-Commit-Position: refs/heads/master@{#388633}