Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 1898033003: Revert https://codereview.chromium.org/1871233002 (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, tdresser+watch_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, Randy Smith (Not in Mondays), dtapuska+chromiumwatch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, kalyank, loading-reviews_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org, hans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert https://codereview.chromium.org/1871233002 -- Move LatencyInfo to ui/latency_info It broke linking most test binaries in release component builds on Windows (http://crbug.com/601871) BUG=601871 R=fsamuel@chromium.org TBR=fsamuel CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078 Cr-Commit-Position: refs/heads/master@{#388261}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -1319 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M build/all.gyp View 5 chunks +0 lines, -5 lines 0 comments Download
M cc/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M cc/cc.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/cc_tests.gyp View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/compositor_frame_metadata.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/latency_info_swap_promise.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/display.h View 1 chunk +1 line, -1 line 0 comments Download
M content/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/in_process/synchronous_input_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/image_transport_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/software_browser_compositor_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_scheduler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/non_blocking_event_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/render_widget_host_latency_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_target_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_pointer_action.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_tap_gesture.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_touchscreen_pinch_gesture.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_action_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_input_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/common/accelerated_surface_buffers_swapped_params_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu_host_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/event_with_latency_info.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/input_event.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/input_event_ack.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_common.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/browser_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/android/synchronous_compositor_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/main_thread_event_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/render_widget_input_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/mus/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/mus/compositor_mus_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/gpu_ipc_client.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/gpu_ipc_common.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/gpu_ipc_service.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/ipc/client/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/client/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/ipc/client/command_buffer_proxy_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/client/gpu_channel_host.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/common/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/common/gpu_messages.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/ipc/service/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/gpu_channel_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/gpu_command_buffer_stub.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/image_transport_surface_overlay_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/pass_through_image_transport_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/BUILD.gn View 1 2 6 chunks +5 lines, -2 lines 0 comments Download
M ui/events/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/events/blink/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/events/blink/events_blink.gyp View 2 chunks +1 line, -2 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/blink/input_handler_proxy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/event.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/events.gyp View 3 chunks +20 lines, -1 line 0 comments Download
M ui/events/events_unittests.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
A + ui/events/ipc/BUILD.gn View 1 chunk +5 lines, -7 lines 0 comments Download
A + ui/events/ipc/OWNERS View 1 chunk +3 lines, -4 lines 0 comments Download
A ui/events/ipc/events_ipc_export.h View 1 chunk +29 lines, -0 lines 0 comments Download
A + ui/events/ipc/latency_info_param_traits.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + ui/events/ipc/latency_info_param_traits.cc View 3 chunks +11 lines, -10 lines 0 comments Download
A + ui/events/ipc/latency_info_param_traits_macros.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + ui/events/ipc/latency_info_param_traits_unittest.cc View 3 chunks +12 lines, -10 lines 0 comments Download
A + ui/events/latency_info.h View 6 chunks +8 lines, -9 lines 0 comments Download
A + ui/events/latency_info.cc View 13 chunks +57 lines, -38 lines 0 comments Download
A + ui/events/latency_info.dot View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/events/latency_info_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/latency_info/BUILD.gn View 1 chunk +0 lines, -42 lines 0 comments Download
D ui/latency_info/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D ui/latency_info/ipc/BUILD.gn View 1 chunk +0 lines, -24 lines 0 comments Download
D ui/latency_info/ipc/OWNERS View 1 chunk +0 lines, -13 lines 0 comments Download
D ui/latency_info/ipc/latency_info_ipc_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ui/latency_info/ipc/latency_info_param_traits.h View 1 chunk +0 lines, -23 lines 0 comments Download
D ui/latency_info/ipc/latency_info_param_traits.cc View 1 chunk +0 lines, -86 lines 0 comments Download
D ui/latency_info/ipc/latency_info_param_traits_macros.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ui/latency_info/ipc/latency_info_param_traits_unittest.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D ui/latency_info/latency_info.h View 1 chunk +0 lines, -244 lines 0 comments Download
D ui/latency_info/latency_info.cc View 1 chunk +0 lines, -364 lines 0 comments Download
D ui/latency_info/latency_info.dot View 1 chunk +0 lines, -36 lines 0 comments Download
D ui/latency_info/latency_info.gyp View 1 chunk +0 lines, -46 lines 0 comments Download
D ui/latency_info/latency_info_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ui/latency_info/latency_info_unittest.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D ui/latency_info/latency_info_unittests.gyp View 1 chunk +0 lines, -33 lines 0 comments Download
M ui/views/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/views.gyp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898033003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898033003/20001
4 years, 8 months ago (2016-04-19 16:11:45 UTC) #6
Nico
4 years, 8 months ago (2016-04-19 16:15:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898033003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898033003/20001
4 years, 8 months ago (2016-04-19 16:16:05 UTC) #11
Fady Samuel
lgtm
4 years, 8 months ago (2016-04-19 16:37:19 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/56246)
4 years, 8 months ago (2016-04-19 17:24:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898033003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898033003/40001
4 years, 8 months ago (2016-04-19 17:46:46 UTC) #17
Nico
Committed patchset #3 (id:40001) manually as 9d6e129498c0bf89ae1461b8930aceb05baaf078 (presubmit successful).
4 years, 8 months ago (2016-04-19 18:56:52 UTC) #19
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:32 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9d6e129498c0bf89ae1461b8930aceb05baaf078
Cr-Commit-Position: refs/heads/master@{#388261}

Powered by Google App Engine
This is Rietveld 408576698