Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 1871233002: Move LatencyInfo to ui/latency_info (Closed)

Created:
4 years, 8 months ago by Fady Samuel
Modified:
4 years ago
Reviewers:
sky, jam, tdresser, dcheng, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, tdresser+watch_chromium.org, nasko+codewatch_chromium.org, jam, Randy Smith (Not in Mondays), dtapuska+chromiumwatch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, kalyank, loading-reviews_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move LatencyInfo to ui/latency_info Components such as cc/ and gpu/ that depend on ui::LatencyInfo should not pull in all of ui/events. This CL pulls ui::LatencyInfo into a separate component to simplify this dependency. cc/ and gpu/ no longer depend on ui/events. BUG=601871 TBR=jam@chromium.org for top level BUILD.gn and build/all.gyp CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993 Cr-Commit-Position: refs/heads/master@{#386889} Committed: https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456 Cr-Commit-Position: refs/heads/master@{#386992}

Patch Set 1 #

Patch Set 2 : Towards GYP build #

Patch Set 3 : Fixed some deps #

Patch Set 4 : Fixed more deps #

Patch Set 5 : Fixed even more DEPS! w00t! #

Patch Set 6 : Added unittest targets #

Patch Set 7 : OWNERS + missing GYP #

Patch Set 8 : More fixes #

Patch Set 9 : Yet Another Dep (YAD) #

Patch Set 10 : cc/surfaces no longer depends on events + latency_info_unittests in gn_all #

Patch Set 11 : Remove unnecessary ipc dependency in ui/latency_info #

Patch Set 12 : Simplify ui/events OWNERS #

Total comments: 10

Patch Set 13 : Addressed nits #

Patch Set 14 : Rebased #

Patch Set 15 : Attempt to fix Win GN build #

Patch Set 16 : Rebase #

Patch Set 17 : Fix typo #

Patch Set 18 : Fixed build issues #

Patch Set 19 : Fix some more gyp issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+370 lines, -1223 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M ash/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M ash/ash.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M build/all.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 5 chunks +5 lines, -0 lines 0 comments Download
M cc/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +2 lines, -2 lines 0 comments Download
M cc/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M cc/cc.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +2 lines, -2 lines 0 comments Download
M cc/cc_tests.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M cc/output/compositor_frame_metadata.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/latency_info_swap_promise.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/display.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/libgtk2ui.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M components/arc.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M components/exo.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/test_runner.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M content/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/compositor/image_transport_factory.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/software_browser_compositor_output_surface.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_scheduler_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/non_blocking_event_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/render_widget_host_latency_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_target_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_pointer_action.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_tap_gesture.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_touchscreen_pinch_gesture.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_action_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_input_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M content/common/accelerated_surface_buffers_swapped_params_mac.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu_host_messages.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/event_with_latency_info.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/input_event.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/input_event_ack.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/common/input_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -0 lines 0 comments Download
M content/gpu/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/browser_test_utils.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/android/synchronous_compositor_proxy.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/main_thread_event_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/render_widget_input_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/mus/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M gpu/gpu_ipc_client.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/gpu_ipc_common.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -2 lines 0 comments Download
M gpu/gpu_ipc_service.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -2 lines 0 comments Download
M gpu/ipc/client/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/client/DEPS View 1 chunk +1 line, -2 lines 0 comments Download
M gpu/ipc/client/command_buffer_proxy_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/client/gpu_channel_host.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/common/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/common/DEPS View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/common/gpu_messages.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/ipc/service/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/DEPS View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/gpu_channel_manager_delegate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/gpu_command_buffer_stub.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/image_transport_surface_overlay_mac.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/pass_through_image_transport_surface.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M media/media.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M ui/accelerated_widget_mac/accelerated_widget_mac.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/presenter/app_list_presenter.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/aura.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +3 lines, -0 lines 0 comments Download
M ui/base/ime/ui_base_ime.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ui_base.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ui_base_tests.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 6 chunks +2 lines, -5 lines 0 comments Download
M ui/events/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/OWNERS View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -3 lines 0 comments Download
M ui/events/blink/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/blink/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/blink/events_blink.gyp View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -1 line 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M ui/events/blink/input_handler_proxy_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M ui/events/event.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M ui/events/events.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +1 line, -20 lines 0 comments Download
M ui/events/events_unittests.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +0 lines, -3 lines 0 comments Download
D ui/events/ipc/BUILD.gn View 1 chunk +0 lines, -22 lines 0 comments Download
D ui/events/ipc/OWNERS View 1 chunk +0 lines, -12 lines 0 comments Download
D ui/events/ipc/events_ipc_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ui/events/ipc/latency_info_param_traits.h View 1 chunk +0 lines, -23 lines 0 comments Download
D ui/events/ipc/latency_info_param_traits.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D ui/events/ipc/latency_info_param_traits_macros.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ui/events/ipc/latency_info_param_traits_unittest.cc View 1 chunk +0 lines, -82 lines 0 comments Download
D ui/events/latency_info.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +0 lines, -248 lines 0 comments Download
D ui/events/latency_info.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +0 lines, -385 lines 0 comments Download
D ui/events/latency_info.dot View 1 chunk +0 lines, -36 lines 0 comments Download
M ui/events/latency_info_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -70 lines 0 comments Download
M ui/events/ozone/events_ozone.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +2 lines, -0 lines 0 comments Download
M ui/events/platform/x11/x11_events_platform.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/keyboard.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +1 line, -0 lines 0 comments Download
A ui/latency_info/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +42 lines, -0 lines 0 comments Download
A + ui/latency_info/OWNERS View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
A + ui/latency_info/ipc/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 1 chunk +7 lines, -5 lines 0 comments Download
A + ui/latency_info/ipc/OWNERS View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/latency_info/ipc/latency_info_ipc_export.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +29 lines, -0 lines 0 comments Download
A + ui/latency_info/ipc/latency_info_param_traits.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + ui/latency_info/ipc/latency_info_param_traits.cc View 3 chunks +10 lines, -11 lines 0 comments Download
A + ui/latency_info/ipc/latency_info_param_traits_macros.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + ui/latency_info/ipc/latency_info_param_traits_unittest.cc View 3 chunks +10 lines, -12 lines 0 comments Download
A + ui/latency_info/latency_info.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 6 chunks +8 lines, -7 lines 0 comments Download
A + ui/latency_info/latency_info.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 13 chunks +38 lines, -57 lines 0 comments Download
A + ui/latency_info/latency_info.dot View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/latency_info/latency_info.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +46 lines, -0 lines 0 comments Download
A ui/latency_info/latency_info_export.h View 1 1 chunk +29 lines, -0 lines 0 comments Download
A + ui/latency_info/latency_info_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A ui/latency_info/latency_info_unittests.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +33 lines, -0 lines 0 comments Download
M ui/platform_window/android/android_window.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/views.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -0 lines 0 comments Download
M ui/wm/wm.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 104 (53 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871233002/20001
4 years, 8 months ago (2016-04-09 14:37:57 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/142410)
4 years, 8 months ago (2016-04-09 14:41:48 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871233002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871233002/40001
4 years, 8 months ago (2016-04-11 20:53:15 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/185480)
4 years, 8 months ago (2016-04-11 21:06:08 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871233002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871233002/60001
4 years, 8 months ago (2016-04-11 21:47:36 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/167163)
4 years, 8 months ago (2016-04-11 22:03:48 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871233002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871233002/80001
4 years, 8 months ago (2016-04-11 22:25:23 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/167187)
4 years, 8 months ago (2016-04-11 22:40:13 UTC) #18
Fady Samuel
+tdresser@ for latency_info +sky@ for ui OWNER
4 years, 8 months ago (2016-04-11 23:19:59 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871233002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871233002/120001
4 years, 8 months ago (2016-04-11 23:20:55 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/167219)
4 years, 8 months ago (2016-04-11 23:36:26 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871233002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871233002/140001
4 years, 8 months ago (2016-04-12 01:04:15 UTC) #28
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/167287)
4 years, 8 months ago (2016-04-12 01:17:52 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871233002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871233002/160001
4 years, 8 months ago (2016-04-12 02:39:14 UTC) #32
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/167326)
4 years, 8 months ago (2016-04-12 02:50:50 UTC) #34
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871233002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871233002/160001
4 years, 8 months ago (2016-04-12 03:58:00 UTC) #36
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/167354)
4 years, 8 months ago (2016-04-12 04:10:01 UTC) #38
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871233002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871233002/180001
4 years, 8 months ago (2016-04-12 10:29:06 UTC) #40
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871233002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871233002/200001
4 years, 8 months ago (2016-04-12 10:38:18 UTC) #42
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871233002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871233002/220001
4 years, 8 months ago (2016-04-12 10:42:38 UTC) #44
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/167445)
4 years, 8 months ago (2016-04-12 10:53:00 UTC) #46
Fady Samuel
+piman@ for cc and gpu and content.
4 years, 8 months ago (2016-04-12 14:53:45 UTC) #48
piman
LGTM
4 years, 8 months ago (2016-04-12 15:06:16 UTC) #49
tdresser
LGTM https://codereview.chromium.org/1871233002/diff/220001/ui/events/events.gyp File ui/events/events.gyp (right): https://codereview.chromium.org/1871233002/diff/220001/ui/events/events.gyp#newcode105 ui/events/events.gyp:105: Remove blank line.
4 years, 8 months ago (2016-04-12 17:45:13 UTC) #50
sky
LGTM https://codereview.chromium.org/1871233002/diff/220001/ui/latency_info/BUILD.gn File ui/latency_info/BUILD.gn (right): https://codereview.chromium.org/1871233002/diff/220001/ui/latency_info/BUILD.gn#newcode1 ui/latency_info/BUILD.gn:1: # Copyright 2014 The Chromium Authors. All rights ...
4 years, 8 months ago (2016-04-12 17:51:59 UTC) #51
Fady Samuel
+dcheng@ for various ipc files and directories. +jam@ for top level https://codereview.chromium.org/1871233002/diff/220001/ui/events/events.gyp File ui/events/events.gyp (right): ...
4 years, 8 months ago (2016-04-12 19:18:04 UTC) #53
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871233002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871233002/240001
4 years, 8 months ago (2016-04-12 19:19:13 UTC) #55
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-12 20:28:40 UTC) #57
dcheng
lgtm
4 years, 8 months ago (2016-04-12 23:05:09 UTC) #58
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871233002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871233002/240001
4 years, 8 months ago (2016-04-12 23:09:23 UTC) #61
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/167803)
4 years, 8 months ago (2016-04-12 23:18:54 UTC) #63
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871233002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871233002/260001
4 years, 8 months ago (2016-04-12 23:56:31 UTC) #66
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/167836)
4 years, 8 months ago (2016-04-13 00:12:32 UTC) #68
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871233002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871233002/260001
4 years, 8 months ago (2016-04-13 01:32:12 UTC) #71
commit-bot: I haz the power
Committed patchset #14 (id:260001)
4 years, 8 months ago (2016-04-13 01:40:20 UTC) #73
commit-bot: I haz the power
Patchset 14 (id:??) landed as https://crrev.com/168cca4ea0abb22aa05575ec94c35d429dc08993 Cr-Commit-Position: refs/heads/master@{#386889}
4 years, 8 months ago (2016-04-13 01:41:34 UTC) #75
vabr (Chromium)
This seems to have broken Win GN compilation, will revert.
4 years, 8 months ago (2016-04-13 07:23:16 UTC) #76
vabr (Chromium)
A revert of this CL (patchset #14 id:260001) has been created in https://codereview.chromium.org/1883763002/ by vabr@chromium.org. ...
4 years, 8 months ago (2016-04-13 07:25:31 UTC) #77
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871233002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871233002/280001
4 years, 8 months ago (2016-04-13 13:12:05 UTC) #81
commit-bot: I haz the power
Committed patchset #15 (id:280001)
4 years, 8 months ago (2016-04-13 15:12:30 UTC) #83
commit-bot: I haz the power
Patchset 15 (id:??) landed as https://crrev.com/7cc1dcccd28336397a468d1d5caa3be92675b456 Cr-Commit-Position: refs/heads/master@{#386992}
4 years, 8 months ago (2016-04-13 15:14:58 UTC) #85
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871233002/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871233002/300001
4 years, 7 months ago (2016-05-02 16:44:27 UTC) #88
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/85442) cast_shell_android on ...
4 years, 7 months ago (2016-05-02 16:52:42 UTC) #90
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871233002/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871233002/320001
4 years, 7 months ago (2016-05-02 17:11:04 UTC) #92
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/131030) chromeos_x86-generic_chromium_compile_only_ng on ...
4 years, 7 months ago (2016-05-02 17:23:34 UTC) #94
jam
lgtm
4 years, 7 months ago (2016-05-02 19:01:44 UTC) #95
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871233002/340001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871233002/340001
4 years, 7 months ago (2016-05-02 19:03:49 UTC) #97
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/194335)
4 years, 7 months ago (2016-05-02 19:20:28 UTC) #99
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871233002/360001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871233002/360001
4 years, 7 months ago (2016-05-02 20:43:28 UTC) #101
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 00:01:58 UTC) #103
tdresser
4 years ago (2016-11-28 15:28:41 UTC) #104
I assume you've dropped this?

Powered by Google App Engine
This is Rietveld 408576698