Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1898003002:
[Findit] Fixing when try job entities are created (Closed)
Description[Findit] Fixing when try job entities are created
https://codereview.chromium.org/1898493002/ adds logic for bailing out for test try jobs, but creates try job entities regardless. This change is to move the creation of try job entities closer to when they will actually be triggered.
Adding notry=true (try jobs work on all but infa_linux_trusty_64_tests, currently experiencing issues)
BUG=
NOTRY=true
Committed: https://chromium.googlesource.com/infra/infra/+/2bdbbba11bb8af3a2e05c81123014c7c2441f9df
Patch Set 1 #Patch Set 2 : Fixing whitespace #
Total comments: 1
Patch Set 3 : Addressing comments #
Messages
Total messages: 22 (11 generated)
Description was changed from ========== [Findit] Fixing when try job entities are created BUG= ========== to ========== [Findit] Fixing when try job entities are created https://codereview.chromium.org/1898493002/ adds logic for bailing out for test try jobs, but creates try job entities regardless. This change is to move the creation of try job entities closer to when they will actually be triggered. BUG= ==========
lijeffrey@chromium.org changed reviewers: + chanli@chromium.org, stgao@chromium.org
ptal
https://codereview.chromium.org/1898003002/diff/20001/appengine/findit/waterf... File appengine/findit/waterfall/try_job_util.py (right): https://codereview.chromium.org/1898003002/diff/20001/appengine/findit/waterf... appengine/findit/waterfall/try_job_util.py:167: try_job = WfTryJob.Create(master_name, builder_name, build_number) No, we'd better not do it like this. If there are two pipeline running in parallel, we might trigger two try-jobs with this change. I thought I have added the failure type to ``failure_info``, can we use that for the checking above?
Comments addressed, ptal
Comments addressed, ptal
lgtm
The CQ bit was checked by lijeffrey@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898003002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898003002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Infra Linux Trusty 64 Tester on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Linux%20Trusty%...)
The CQ bit was checked by lijeffrey@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898003002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898003002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Infra Linux Trusty 64 Tester on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Linux%20Trusty%...)
Description was changed from ========== [Findit] Fixing when try job entities are created https://codereview.chromium.org/1898493002/ adds logic for bailing out for test try jobs, but creates try job entities regardless. This change is to move the creation of try job entities closer to when they will actually be triggered. BUG= ========== to ========== [Findit] Fixing when try job entities are created https://codereview.chromium.org/1898493002/ adds logic for bailing out for test try jobs, but creates try job entities regardless. This change is to move the creation of try job entities closer to when they will actually be triggered. BUG= NOTRY=true ==========
Description was changed from ========== [Findit] Fixing when try job entities are created https://codereview.chromium.org/1898493002/ adds logic for bailing out for test try jobs, but creates try job entities regardless. This change is to move the creation of try job entities closer to when they will actually be triggered. BUG= NOTRY=true ========== to ========== [Findit] Fixing when try job entities are created https://codereview.chromium.org/1898493002/ adds logic for bailing out for test try jobs, but creates try job entities regardless. This change is to move the creation of try job entities closer to when they will actually be triggered. BUG= NOTRY=true (try jobs work on all but infa_linux_trusty_64_tests) ==========
Description was changed from ========== [Findit] Fixing when try job entities are created https://codereview.chromium.org/1898493002/ adds logic for bailing out for test try jobs, but creates try job entities regardless. This change is to move the creation of try job entities closer to when they will actually be triggered. BUG= NOTRY=true (try jobs work on all but infa_linux_trusty_64_tests) ========== to ========== [Findit] Fixing when try job entities are created https://codereview.chromium.org/1898493002/ adds logic for bailing out for test try jobs, but creates try job entities regardless. This change is to move the creation of try job entities closer to when they will actually be triggered. Adding notry=true (try jobs work on all but infa_linux_trusty_64_tests, currently experiencing issues) BUG= NOTRY=true ==========
The CQ bit was checked by lijeffrey@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898003002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898003002/40001
Message was sent while issue was closed.
Description was changed from ========== [Findit] Fixing when try job entities are created https://codereview.chromium.org/1898493002/ adds logic for bailing out for test try jobs, but creates try job entities regardless. This change is to move the creation of try job entities closer to when they will actually be triggered. Adding notry=true (try jobs work on all but infa_linux_trusty_64_tests, currently experiencing issues) BUG= NOTRY=true ========== to ========== [Findit] Fixing when try job entities are created https://codereview.chromium.org/1898493002/ adds logic for bailing out for test try jobs, but creates try job entities regardless. This change is to move the creation of try job entities closer to when they will actually be triggered. Adding notry=true (try jobs work on all but infa_linux_trusty_64_tests, currently experiencing issues) BUG= NOTRY=true Committed: https://chromium.googlesource.com/infra/infra/+/2bdbbba11bb8af3a2e05c81123014... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/infra/infra/+/2bdbbba11bb8af3a2e05c81123014... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
