[Findit] Fixing when try job entities are created

appengine/findit/waterfall/try_job_util.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 
 from google.appengine.ext import ndb
 
 from common import appengine_util
 from common import constants
@@ skipping 79 matching lines @@
         master_name, builder_name, build_number,
         failure_result_map, TryJobType.COMPILE, failed_steps['compile'])
   else:
     try_job_type = TryJobType.TEST
     targeted_tests, need_new_try_job, last_pass = (
         _CheckIfNeedNewTryJobForTestFailure(
             'step', master_name, builder_name, build_number, failure_result_map,
             failed_steps))
 
   if need_new_try_job:
-    try_job = WfTryJob.Get(
-        master_name, builder_name, build_number)
+    try_job = WfTryJob.Get(master_name, builder_name, build_number)
 
     if try_job:
       if try_job.failed:
         try_job.status = analysis_status.PENDING
         try_job.put()
       else:
         need_new_try_job = False
-    else:
-      try_job = WfTryJob.Create(
-          master_name, builder_name, build_number)
-      try_job.put()
 
   return need_new_try_job, last_pass, try_job_type, targeted_tests
 
 
 def _GetFailedTargetsFromSignals(signals, master_name, builder_name):
   compile_targets = []
 
   if not signals or 'compile' not in signals:
     return compile_targets
 
@@ skipping 39 matching lines @@
       _NeedANewTryJob(master_name, builder_name, build_number,
                       failed_steps, failure_result_map))
 
   if (try_job_type == TryJobType.TEST and
       waterfall_config.ShouldSkipTestTryJobs(master_name, builder_name)):
     logging.info('Test try jobs on %s, %s are not supported yet.',
                  master_name, builder_name)
     return {}
 
   if need_new_try_job:
+    try_job = WfTryJob.Create(master_name, builder_name, build_number)

[stgao, 2016/04/18 22:05:27]

No, we'd better not do it like this.
If there are two pipeline running in parallel, we might trigger two try-jobs
with this change.

I thought I have added the failure type to ``failure_info``, can we use that for
the checking above?

+    try_job.put()
+
     compile_targets = (_GetFailedTargetsFromSignals(
         signals, master_name, builder_name)
                        if try_job_type == TryJobType.COMPILE else None)
     suspected_revisions = (
         _GetSuspectsForCompileFailureFromHeuristicResult(heuristic_result)
         if try_job_type == TryJobType.COMPILE else None)
 
     pipeline = (
         swarming_tasks_to_try_job_pipeline.SwarmingTasksToTryJobPipeline(
             master_name, builder_name, build_number,
@@ skipping 15 matching lines @@
               pipeline.pipeline_status_path, try_job_type)
     else:  # pragma: no cover
       logging_str = (
           'Try job was scheduled for build %s, %s, %s: %s because of %s '
           'failure.') % (
               master_name, builder_name, build_number,
               pipeline.pipeline_status_path, try_job_type)
     logging.info(logging_str)
 
   return failure_result_map