Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1897873003: bluetooth: Check if device name is null before trying to convert (Closed)

Created:
4 years, 8 months ago by ortuno
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

bluetooth: Check if device name is null before trying to convert Since http://crrev.com/1828193002 ConvertJavaStringToUTF8 crashes when passed in null. To avoid that we first check if the name returned by android is null and if so return an empty string. BUG=602189 Review URL: https://codereview.chromium.org/1876753004 Cr-Commit-Position: refs/heads/master@{#386733} (cherry picked from commit baefa2c7c7188832268e60b063103673edf8a34f) Committed: https://chromium.googlesource.com/chromium/src/+/da2f05663a306485d1a846267c6d65519387c5af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
M device/bluetooth/bluetooth_device.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device_android.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_device_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java View 1 chunk +8 lines, -0 lines 0 comments Download
M device/bluetooth/test/bluetooth_test.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ortuno
4 years, 8 months ago (2016-04-19 16:18:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
da2f05663a306485d1a846267c6d65519387c5af.

Powered by Google App Engine
This is Rietveld 408576698