bluetooth: Check if device name is null before trying to convert

bluetooth: Check if device name is null before trying to convert

Since http://crrev.com/1828193002 ConvertJavaStringToUTF8 crashes
when passed in null. To avoid that we first check if the
name returned by android is null and if so return an empty string.

BUG=602189
Committed: https://crrev.com/baefa2c7c7188832268e60b063103673edf8a34f
Cr-Commit-Position: refs/heads/master@{#386733}

[ortuno, 2016-04-11 17:51:01]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2016-04-11 17:51:02]

scheib: PTAL

[scheib, 2016-04-11 17:58:13]

https://codereview.chromium.org/1876753004/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_device_unittest.cc (right):

https://codereview.chromium.org/1876753004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_device_unittest.cc:128:
EXPECT_EQ("FakeBluetoothDevice", device->GetDeviceName());
We already have LowEnergyDeviceProperties that tests GetName with a non-empty
value.

https://codereview.chromium.org/1876753004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_device_unittest.cc:141: BluetoothDevice* device =
DiscoverLowEnergyDevice(5);
Document '5' in bluetooth/test/bluetooth_test.h

[ortuno, 2016-04-11 18:11:58]

https://codereview.chromium.org/1876753004/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_device_unittest.cc (right):

https://codereview.chromium.org/1876753004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_device_unittest.cc:128:
EXPECT_EQ("FakeBluetoothDevice", device->GetDeviceName());
On 2016/04/11 at 17:58:12, scheib wrote:
> We already have LowEnergyDeviceProperties that tests GetName with a non-empty
value.

Removed the test. Should I add a call to GetDeviceName in the
LowEnergyDeviceProperties test?

https://codereview.chromium.org/1876753004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_device_unittest.cc:141: BluetoothDevice* device =
DiscoverLowEnergyDevice(5);
On 2016/04/11 at 17:58:12, scheib wrote:
> Document '5' in bluetooth/test/bluetooth_test.h

Done.

[scheib, 2016-04-12 05:05:55]

https://codereview.chromium.org/1876753004/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_device_unittest.cc (right):

https://codereview.chromium.org/1876753004/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_device_unittest.cc:128: EXPECT_EQ("",
device->GetDeviceName());
Why can't this test GetName(), the public API?

[ortuno, 2016-04-12 14:42:33]

https://codereview.chromium.org/1876753004/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_device_unittest.cc (right):

https://codereview.chromium.org/1876753004/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_device_unittest.cc:128: EXPECT_EQ("",
device->GetDeviceName());
On 2016/04/12 at 05:05:55, scheib wrote:
> Why can't this test GetName(), the public API?

See TODO below. http://crbug.com/506415

[ortuno, 2016-04-12 14:45:51]

Description was changed from

==========
bluetooth: Check if device name is null before trying to convert

Since http://crrev.com/1828193002 ConvertJavaStringToUTF8 crashes
when passed in null. To avoid that we first check if the
name returned by android is null and if so return an empty string.

BUG=506415
==========

to

==========
bluetooth: Check if device name is null before trying to convert

Since http://crrev.com/1828193002 ConvertJavaStringToUTF8 crashes
when passed in null. To avoid that we first check if the
name returned by android is null and if so return an empty string.

BUG=506415, 602189
==========

[ortuno, 2016-04-12 14:46:06]

Description was changed from

==========
bluetooth: Check if device name is null before trying to convert

Since http://crrev.com/1828193002 ConvertJavaStringToUTF8 crashes
when passed in null. To avoid that we first check if the
name returned by android is null and if so return an empty string.

BUG=506415, 602189
==========

to

==========
bluetooth: Check if device name is null before trying to convert

Since http://crrev.com/1828193002 ConvertJavaStringToUTF8 crashes
when passed in null. To avoid that we first check if the
name returned by android is null and if so return an empty string.

BUG=602189
==========

[scheib, 2016-04-12 16:25:29]

LGTM

[ortuno, 2016-04-12 16:26:14]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2016-04-12 16:26:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1876753004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1876753004/20001

[commit-bot: I haz the power, 2016-04-12 17:34:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-12 17:36:27]

Description was changed from

==========
bluetooth: Check if device name is null before trying to convert

Since http://crrev.com/1828193002 ConvertJavaStringToUTF8 crashes
when passed in null. To avoid that we first check if the
name returned by android is null and if so return an empty string.

BUG=602189
==========

to

==========
bluetooth: Check if device name is null before trying to convert

Since http://crrev.com/1828193002 ConvertJavaStringToUTF8 crashes
when passed in null. To avoid that we first check if the
name returned by android is null and if so return an empty string.

BUG=602189

Committed: https://crrev.com/baefa2c7c7188832268e60b063103673edf8a34f
Cr-Commit-Position: refs/heads/master@{#386733}
==========

[commit-bot: I haz the power, 2016-04-12 17:36:28]

Patchset 2 (id:??) landed as
https://crrev.com/baefa2c7c7188832268e60b063103673edf8a34f
Cr-Commit-Position: refs/heads/master@{#386733}