Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1897863007: Make backend and reporter customizable. (Closed)

Created:
4 years, 8 months ago by ahe
Modified:
4 years, 8 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merged with 09c242e729de2e488cd36960fe2a4a882421086c #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -15 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/common/backend_api.dart View 3 chunks +11 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 6 chunks +21 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
Based on the following Dartino patches: https://codereview.chromium.org/1581943003 https://codereview.chromium.org//1317053003 I'm trying to land this in master ...
4 years, 8 months ago (2016-04-20 16:03:54 UTC) #2
Johnni Winther
lgtm
4 years, 8 months ago (2016-04-25 10:19:43 UTC) #3
ahe
4 years, 8 months ago (2016-04-25 12:31:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
74144aece4b9c6eb9c63ea1de26423b53d1f7286 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698