Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1581943003: Make reporter customizable (Closed)

Created:
4 years, 11 months ago by ahe
Modified:
4 years, 11 months ago
Reviewers:
Johnni Winther, zarah
CC:
fletch+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/_temporary_fletch_patches
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased on d4e8946f9b7c6f3b87655563e0a1999857ad03a3 #

Patch Set 3 : No changes, hopefully #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -19 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 4 chunks +38 lines, -12 lines 3 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 6 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ahe
4 years, 11 months ago (2016-01-13 15:59:10 UTC) #2
zarah
LGTM
4 years, 11 months ago (2016-01-14 10:27:55 UTC) #3
ahe
Committed patchset #3 (id:60001) manually as c0969fd33bd4f271c57e64a25aaba75800b0ccef (presubmit successful).
4 years, 11 months ago (2016-01-18 08:59:57 UTC) #6
Johnni Winther
LGTM Will you port these to bleeding_edge? https://codereview.chromium.org/1581943003/diff/60001/pkg/compiler/lib/src/apiimpl.dart File pkg/compiler/lib/src/apiimpl.dart (right): https://codereview.chromium.org/1581943003/diff/60001/pkg/compiler/lib/src/apiimpl.dart#newcode101 pkg/compiler/lib/src/apiimpl.dart:101: MakeBackendFuncion makeBackend, ...
4 years, 11 months ago (2016-01-21 08:52:58 UTC) #7
ahe
Thank you, Johnni. I have no current plans of porting this to sdk master. https://codereview.chromium.org/1581943003/diff/60001/pkg/compiler/lib/src/apiimpl.dart ...
4 years, 11 months ago (2016-01-22 11:04:49 UTC) #8
ahe
4 years, 11 months ago (2016-01-22 11:58:22 UTC) #9
Message was sent while issue was closed. 
https://codereview.chromium.org/1581943003/diff/60001/pkg/compiler/lib/src/ap...
File pkg/compiler/lib/src/apiimpl.dart (right):

https://codereview.chromium.org/1581943003/diff/60001/pkg/compiler/lib/src/ap...
pkg/compiler/lib/src/apiimpl.dart:101: MakeBackendFuncion makeBackend,
On 2016/01/22 11:04:49, ahe wrote:
> On 2016/01/21 08:52:58, Johnni Winther wrote:
> > MakeBackendFuncion -> MakeBackendFuncion
> 
> What would be the point of that :-P

Fixed in CL 1617183003.

Powered by Google App Engine
This is Rietveld 408576698