Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1897833003: [sanitizers] Using correct dynamic linking option on mac. (Closed)

Created:
4 years, 8 months ago by aizatsky
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sanitizers] Using correct dynamic linking option on mac. BUG=597066 Committed: https://crrev.com/d476d8d12ec348f2f8ceb7012f6cb56369c7fb16 Cr-Commit-Position: refs/heads/master@{#388051}

Patch Set 1 #

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/config/sanitizers/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
aizatsky
4 years, 8 months ago (2016-04-18 21:05:09 UTC) #3
brettw
lgtm
4 years, 8 months ago (2016-04-18 21:09:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897833003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897833003/20001
4 years, 8 months ago (2016-04-18 21:18:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-18 22:28:40 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 22:31:05 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d476d8d12ec348f2f8ceb7012f6cb56369c7fb16
Cr-Commit-Position: refs/heads/master@{#388051}

Powered by Google App Engine
This is Rietveld 408576698