build/config/sanitizers/BUILD.gn - Issue 1897833003: [sanitizers] Using correct dynamic linking option on mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/sanitizers/BUILD.gn

Issue 1897833003: [sanitizers] Using correct dynamic linking option on mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/sanitizers/BUILD.gn

diff --git a/build/config/sanitizers/BUILD.gn b/build/config/sanitizers/BUILD.gn

index ce48fedc86fc74d752a67a4d38179083b157d884..e7e36b5db84422529b68fcf56e244ea317fb9490 100644

--- a/build/config/sanitizers/BUILD.gn

+++ b/build/config/sanitizers/BUILD.gn

@@ -33,7 +33,9 @@ group("deps") {

}

config("sanitizer_options_link_helper") {

- if (!is_win) {

+ if (is_mac) {

+ ldflags = [ "-Wl,-U,_sanitizer_options_link_helper" ]

+ } else if (!is_win) {

ldflags = [ "-Wl,-u_sanitizer_options_link_helper" ]

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »