Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 189783002: Fix UserAction presubmit incorrectly not matching existing actions. (Closed)

Created:
6 years, 9 months ago by Ted C
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix UserAction presubmit incorrectly not matching existing actions. BUG=340735 TBR=maruel@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255530

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Ted C
PTAL Found this while doing this change: https://codereview.chromium.org/177013006/ 'ShowHistory' exists and this wasn't matching because ...
6 years, 9 months ago (2014-03-07 01:46:13 UTC) #1
Ilya Sherman
LGTM, thanks Ted!
6 years, 9 months ago (2014-03-07 01:46:47 UTC) #2
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 9 months ago (2014-03-07 01:46:50 UTC) #3
Ted C
+maruel (TBRing since it's a small change)
6 years, 9 months ago (2014-03-07 01:52:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/189783002/1
6 years, 9 months ago (2014-03-07 01:52:55 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 04:34:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-07 04:34:16 UTC) #7
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 9 months ago (2014-03-07 04:34:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/189783002/1
6 years, 9 months ago (2014-03-07 04:39:17 UTC) #9
commit-bot: I haz the power
Change committed as 255530
6 years, 9 months ago (2014-03-07 04:50:08 UTC) #10
Alexei Svitkine (slow)
6 years, 9 months ago (2014-03-07 15:55:37 UTC) #11
Message was sent while issue was closed.
lgtm, ty

Powered by Google App Engine
This is Rietveld 408576698