PRESUBMIT.py - Issue 189783002: Fix UserAction presubmit incorrectly not matching existing actions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 189783002: Fix UserAction presubmit incorrectly not matching existing actions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 1e6526f26ea9c9dca0f46179f948e5a14216afed..6a0dcbfcffd42bb197de0b12456214c694b32816 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -1030,7 +1030,7 @@ def _CheckUserActionUpdate(input_api, output_api):

match = input_api.re.search(action_re, line)

if match:

for action_name in match.groups():

- name_pattern = r'\t%s\n' % action_name

+ name_pattern = '\t%s\n' % action_name

if name_pattern not in current_actions:

return [output_api.PresubmitPromptWarning(

'File %s line %d: %s is missing in '

« no previous file with comments | « no previous file | no next file » | no next file with comments »