Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1897623002: Remove POSIX shared memory. (Closed)

Created:
4 years, 8 months ago by erikchen
Modified:
4 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, viettrungluu+watch_chromium.org, jam, gavinp+memory_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove POSIX shared memory. The first attempt to land this CL was reverted because it tickled a Mojo bug (Mojo couldn't handle null Mach ports). That has since been fixed: https://codereview.chromium.org/1890043002/ Original CL: https://codereview.chromium.org/1867733002/ BUG=603452 TBR=mark@chromium.org,mseaborn@chromium.org,avi@chromium.org,tsepez@chromium.org,amistry@chromium.org,thakis@chromium.org Committed: https://crrev.com/21fef176d164d23237563e76a280f5012fd5c425 Cr-Commit-Position: refs/heads/master@{#387967}

Patch Set 1 #

Patch Set 2 : Rebase against https://codereview.chromium.org/1890043002/. #

Total comments: 2

Patch Set 3 : Comments from amistry. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -583 lines) Patch
M base/memory/shared_memory.h View 6 chunks +5 lines, -23 lines 0 comments Download
M base/memory/shared_memory_handle.h View 4 chunks +13 lines, -60 lines 0 comments Download
M base/memory/shared_memory_handle_mac.cc View 4 chunks +41 lines, -139 lines 0 comments Download
M base/memory/shared_memory_mac.cc View 8 chunks +19 lines, -240 lines 0 comments Download
M base/memory/shared_memory_unittest.cc View 8 chunks +5 lines, -18 lines 0 comments Download
M components/nacl/loader/nacl_ipc_adapter.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M content/renderer/media/video_capture_message_filter_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 chunk +21 lines, -71 lines 0 comments Download
M mojo/edk/embedder/embedder_unittest.cc View 1 2 3 chunks +0 lines, -5 lines 0 comments Download
M mojo/edk/embedder/platform_shared_buffer.cc View 3 chunks +3 lines, -17 lines 0 comments Download
M mojo/edk/embedder/platform_shared_buffer_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897623002/1
4 years, 8 months ago (2016-04-16 01:18:33 UTC) #3
erikchen
I TBRed all the original reviewers. The only change from the original CL was to ...
4 years, 8 months ago (2016-04-16 01:19:16 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897623002/20001
4 years, 8 months ago (2016-04-16 01:20:25 UTC) #8
Anand Mistry (off Chromium)
https://codereview.chromium.org/1897623002/diff/20001/mojo/edk/embedder/embedder_unittest.cc File mojo/edk/embedder/embedder_unittest.cc (left): https://codereview.chromium.org/1897623002/diff/20001/mojo/edk/embedder/embedder_unittest.cc#oldcode427 mojo/edk/embedder/embedder_unittest.cc:427: POSIX, Please restore this. I changed the test so ...
4 years, 8 months ago (2016-04-16 01:27:54 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/212404)
4 years, 8 months ago (2016-04-16 01:40:24 UTC) #11
Avi (use Gerrit)
Still lgtm with expert approval. stampity stamp
4 years, 8 months ago (2016-04-16 05:53:15 UTC) #12
Avi (use Gerrit)
Still lgtm with expert approval. stampity stamp
4 years, 8 months ago (2016-04-16 05:53:16 UTC) #13
Tom Sepez
On 2016/04/16 05:53:16, Avi (OOO 20 April - 2 May) wrote: > Still lgtm with ...
4 years, 8 months ago (2016-04-18 17:02:17 UTC) #14
erikchen
https://codereview.chromium.org/1897623002/diff/20001/mojo/edk/embedder/embedder_unittest.cc File mojo/edk/embedder/embedder_unittest.cc (left): https://codereview.chromium.org/1897623002/diff/20001/mojo/edk/embedder/embedder_unittest.cc#oldcode427 mojo/edk/embedder/embedder_unittest.cc:427: POSIX, On 2016/04/16 01:27:54, Anand Mistry wrote: > Please ...
4 years, 8 months ago (2016-04-18 17:14:39 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897623002/40001
4 years, 8 months ago (2016-04-18 17:15:09 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-18 18:32:27 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897623002/40001
4 years, 8 months ago (2016-04-18 18:33:43 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-18 18:39:25 UTC) #23
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 18:40:51 UTC) #25
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/21fef176d164d23237563e76a280f5012fd5c425
Cr-Commit-Position: refs/heads/master@{#387967}

Powered by Google App Engine
This is Rietveld 408576698