Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: mojo/edk/embedder/embedder_unittest.cc

Issue 1897623002: Remove POSIX shared memory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments from amistry. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_message_utils.cc ('k') | mojo/edk/embedder/platform_shared_buffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/embedder/embedder_unittest.cc
diff --git a/mojo/edk/embedder/embedder_unittest.cc b/mojo/edk/embedder/embedder_unittest.cc
index b21d898e23b9318d281b5893ec8a5d25fe7746a5..5d38b6e96897139f3aeecc68efa445ac01b7cc8e 100644
--- a/mojo/edk/embedder/embedder_unittest.cc
+++ b/mojo/edk/embedder/embedder_unittest.cc
@@ -303,9 +303,6 @@ TEST_F(EmbedderTest, MAYBE_MultiprocessBaseSharedMemory) {
// from it.
base::SharedMemoryCreateOptions options;
options.size = 123;
-#if defined(OS_MACOSX) && !defined(OS_IOS)
- options.type = base::SharedMemoryHandle::POSIX;
-#endif
base::SharedMemory shared_memory;
ASSERT_TRUE(shared_memory.Create(options));
base::SharedMemoryHandle shm_handle = base::SharedMemory::DuplicateHandle(
@@ -385,7 +382,6 @@ TEST_F(EmbedderTest, MultiprocessMachSharedMemory) {
// buffer from it.
base::SharedMemoryCreateOptions options;
options.size = 123;
- options.type = base::SharedMemoryHandle::MACH;
base::SharedMemory shared_memory;
ASSERT_TRUE(shared_memory.Create(options));
base::SharedMemoryHandle shm_handle = base::SharedMemory::DuplicateHandle(
@@ -460,7 +456,6 @@ TEST_F(EmbedderTest, MultiprocessMixMachAndFds) {
} else {
base::SharedMemoryCreateOptions options;
options.size = kShmSize;
- options.type = base::SharedMemoryHandle::MACH;
base::SharedMemory shared_memory;
ASSERT_TRUE(shared_memory.Create(options));
base::SharedMemoryHandle shm_handle =
« no previous file with comments | « ipc/ipc_message_utils.cc ('k') | mojo/edk/embedder/platform_shared_buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698