chrome/browser/tab_contents/origins_seen_service_factory.h - Issue 1897343003: Componentize OriginsSeenService & provide iOS factory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/origins_seen_service_factory.h

Issue 1897343003: Componentize OriginsSeenService & provide iOS factory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git add components/navigation_metrics/DEPS Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/tab_contents/origins_seen_service.cc ('k') | chrome/browser/tab_contents/origins_seen_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tab_contents/origins_seen_service_factory.h

diff --git a/chrome/browser/tab_contents/origins_seen_service_factory.h b/chrome/browser/tab_contents/origins_seen_service_factory.h

index 6f1fab19f9f1a8ae71ddef2e7e724c51adf26584..7763c36cca8c96e53123e1dc49c9fd7957a01b40 100644

--- a/chrome/browser/tab_contents/origins_seen_service_factory.h

+++ b/chrome/browser/tab_contents/origins_seen_service_factory.h

@@ -6,14 +6,16 @@

#define CHROME_BROWSER_TAB_CONTENTS_ORIGINS_SEEN_SERVICE_FACTORY_H_

#include "base/memory/singleton.h"

-#include "chrome/browser/tab_contents/origins_seen_service.h"

#include "components/keyed_service/content/browser_context_keyed_service_factory.h"

+#include "components/navigation_metrics/origins_seen_service.h"

sky 2016/04/20 19:28:03 Is this include necessary here Doesn't the forward

sdefresne 2016/05/10 09:07:16 No, it is not required, removed.

+namespace navigation_metrics {

class OriginsSeenService;

class OriginsSeenServiceFactory : public BrowserContextKeyedServiceFactory {

public:

- static OriginsSeenService* GetForBrowserContext(

+ static navigation_metrics::OriginsSeenService* GetForBrowserContext(

content::BrowserContext* context);

static OriginsSeenServiceFactory* GetInstance();

« no previous file with comments | « chrome/browser/tab_contents/origins_seen_service.cc ('k') | chrome/browser/tab_contents/origins_seen_service_factory.cc » ('j') | no next file with comments »