chrome/browser/tab_contents/origins_seen_service.cc - Issue 1897343003: Componentize OriginsSeenService & provide iOS factory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/origins_seen_service.cc

Issue 1897343003: Componentize OriginsSeenService & provide iOS factory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git add components/navigation_metrics/DEPS Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/tab_contents/origins_seen_service.h ('k') | chrome/browser/tab_contents/origins_seen_service_factory.h » ('j') | chrome/browser/tab_contents/origins_seen_service_factory.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tab_contents/origins_seen_service.cc

diff --git a/chrome/browser/tab_contents/origins_seen_service.cc b/chrome/browser/tab_contents/origins_seen_service.cc

deleted file mode 100644

index 7d3736650663bb83bcccc2bbc07bcaa9ddfef923..0000000000000000000000000000000000000000

--- a/chrome/browser/tab_contents/origins_seen_service.cc

+++ /dev/null

@@ -1,20 +0,0 @@

-// Use of this source code is governed by a BSD-style license that can be

-// found in the LICENSE file.

-#include "chrome/browser/tab_contents/origins_seen_service.h"

-namespace {

-const size_t kDefaultMRUCacheSize = 1000;

-} // namespace

-OriginsSeenService::OriginsSeenService()

- : origins_seen_(kDefaultMRUCacheSize) {}

-OriginsSeenService::~OriginsSeenService() {}

-bool OriginsSeenService::Insert(const url::Origin& origin) {

- bool seen = origins_seen_.Peek(origin) != origins_seen_.end();

- origins_seen_.Put(origin, true);

- return seen;