chrome/browser/android/ntp/ntp_snippets_bridge.cc - Issue 1897313002: Revert of [NTP Snippets] Refresh the displayed snippets less frequently

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/ntp/ntp_snippets_bridge.cc

Issue 1897313002: Revert of [NTP Snippets] Refresh the displayed snippets less frequently (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java ('k') | components/ntp_snippets/ntp_snippets_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/ntp/ntp_snippets_bridge.cc

diff --git a/chrome/browser/android/ntp/ntp_snippets_bridge.cc b/chrome/browser/android/ntp/ntp_snippets_bridge.cc

index 89211d0d2b6f0483f8eac7bcf289ba92e9938af4..b1154ceb7fe7c429fdbc60cd003f62fc899a03ac 100644

--- a/chrome/browser/android/ntp/ntp_snippets_bridge.cc

+++ b/chrome/browser/android/ntp/ntp_snippets_bridge.cc

@@ -41,14 +41,14 @@

: snippet_service_observer_(this) {

Profile* profile = ProfileAndroid::FromProfileAndroid(j_profile);

ntp_snippets_service_ = NTPSnippetsServiceFactory::GetForProfile(profile);

- snippet_service_observer_.Add(ntp_snippets_service_);

}

void NTPSnippetsBridge::SetObserver(JNIEnv* env,

const JavaParamRef<jobject>& obj,

const JavaParamRef<jobject>& j_observer) {

observer_.Reset(env, j_observer);

- NTPSnippetsServiceLoaded();

+ // This will call NTPSnippetsServiceLoaded.

+ snippet_service_observer_.Add(ntp_snippets_service_);

}

NTPSnippetsBridge::~NTPSnippetsBridge() {}

@@ -65,8 +65,7 @@

}

void NTPSnippetsBridge::NTPSnippetsServiceLoaded() {

- if (observer_.is_null())

- return;

+ DCHECK(!observer_.is_null());

std::vector<std::string> titles;

std::vector<std::string> urls;