Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: pkg/analyzer/test/generated/hint_code_test.dart

Issue 1897293003: Required params message fix. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/error_verifier.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/hint_code_test.dart
diff --git a/pkg/analyzer/test/generated/hint_code_test.dart b/pkg/analyzer/test/generated/hint_code_test.dart
index 168c471b77b27e84b097f4c42aa36ab252430c12..bd5f9ea22656a28f2c8fcfcdf738218ffabf4491 100644
--- a/pkg/analyzer/test/generated/hint_code_test.dart
+++ b/pkg/analyzer/test/generated/hint_code_test.dart
@@ -1605,7 +1605,7 @@ main() {
}
''');
computeLibrarySourceErrors(source);
- assertErrors(source, [HintCode.MISSING_REQUIRED_PARAM]);
+ assertErrors(source, [HintCode.MISSING_REQUIRED_PARAM_WITH_DETAILS]);
Brian Wilkerson 2016/04/19 18:01:16 It would be good to have at least one test of the
pquitslund 2016/04/19 18:20:23 Yep! There are a few actually below...
verify([source]);
}
@@ -1671,7 +1671,7 @@ main() {
}
''');
computeLibrarySourceErrors(source);
- assertErrors(source, [HintCode.MISSING_REQUIRED_PARAM]);
+ assertErrors(source, [HintCode.MISSING_REQUIRED_PARAM_WITH_DETAILS]);
verify([source]);
}
@@ -1686,7 +1686,7 @@ f() {
}
''');
computeLibrarySourceErrors(source);
- assertErrors(source, [HintCode.MISSING_REQUIRED_PARAM]);
+ assertErrors(source, [HintCode.MISSING_REQUIRED_PARAM_WITH_DETAILS]);
verify([source]);
}
@@ -2909,7 +2909,8 @@ library L;
import 'lib1.dart' show A, B;
A a;''');
Source source2 = addNamedSource(
- "/lib1.dart", r'''
+ "/lib1.dart",
+ r'''
library lib1;
class A {}
class B {}''');
@@ -2947,7 +2948,8 @@ library L;
import 'lib1.dart' as p show A, B;
p.A a;''');
Source source2 = addNamedSource(
- "/lib1.dart", r'''
+ "/lib1.dart",
+ r'''
library lib1;
class A {}
class B {}''');
@@ -2965,16 +2967,16 @@ import 'lib1.dart' show C, D;
A a;
C c;''');
Source source2 = addNamedSource(
- "/lib1.dart", r'''
+ "/lib1.dart",
+ r'''
library lib1;
class A {}
class B {}
class C {}
class D {}''');
computeLibrarySourceErrors(source);
- assertErrors(source, [
- HintCode.UNUSED_SHOWN_NAME,
- HintCode.UNUSED_SHOWN_NAME]);
+ assertErrors(
+ source, [HintCode.UNUSED_SHOWN_NAME, HintCode.UNUSED_SHOWN_NAME]);
assertNoErrors(source2);
verify([source, source2]);
}
« no previous file with comments | « pkg/analyzer/lib/src/generated/error_verifier.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698