Required params message fix.

pkg/analyzer/test/generated/hint_code_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.test.generated.hint_code_test;
 
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/error.dart';
 import 'package:analyzer/src/generated/source_io.dart';
 import 'package:unittest/unittest.dart';
@@ skipping 1587 matching lines @@
 
 class C {
   C({@Required('must specify an `a`') int a}) {}
 }
 
 main() {
   new C();
 }
 ''');
     computeLibrarySourceErrors(source);
-    assertErrors(source, [HintCode.MISSING_REQUIRED_PARAM]);
+    assertErrors(source, [HintCode.MISSING_REQUIRED_PARAM_WITH_DETAILS]);

[Brian Wilkerson, 2016/04/19 18:01:16]

It would be good to have at least one test of the no-details version.

[pquitslund, 2016/04/19 18:20:23]

Yep!  There are a few actually below...

     verify([source]);
   }
 
   void test_required_constructor_param_no_reason() {

[pquitslund, 2016/04/19 18:20:23]

Here.

     Source source = addSource(r'''
 import 'package:meta/meta.dart';
 
 class C {
   C({@required int a}) {}
 }
 
 main() {
   new C();
 }
 ''');
     computeLibrarySourceErrors(source);
     assertErrors(source, [HintCode.MISSING_REQUIRED_PARAM]);
     verify([source]);
   }
 
   void test_required_constructor_param_null_reason() {

[pquitslund, 2016/04/19 18:20:23]

And here...

     Source source = addSource(r'''
 import 'package:meta/meta.dart';
 
 class C {
   C({@Required(null) int a}) {}
 }
 
 main() {
   new C();
 }
@@ skipping 24 matching lines @@
     Source source = addSource(r'''
 import 'package:meta/meta.dart';
 
 void f({@Required('must specify an `a`') int a}) {}
 
 main() {
   f();
 }
 ''');
     computeLibrarySourceErrors(source);
-    assertErrors(source, [HintCode.MISSING_REQUIRED_PARAM]);
+    assertErrors(source, [HintCode.MISSING_REQUIRED_PARAM_WITH_DETAILS]);
     verify([source]);
   }
 
   void test_required_method_param() {
     Source source = addSource(r'''
 import 'package:meta/meta.dart';
 class A {
   void m({@Required('must specify an `a`') int a}) {}
 }
 f() {
   new A().m();
 }
 ''');
     computeLibrarySourceErrors(source);
-    assertErrors(source, [HintCode.MISSING_REQUIRED_PARAM]);
+    assertErrors(source, [HintCode.MISSING_REQUIRED_PARAM_WITH_DETAILS]);
     verify([source]);
   }
 
   void test_typeCheck_type_is_Null() {
     Source source = addSource(r'''
 m(i) {
   bool b = i is Null;
 }''');
     computeLibrarySourceErrors(source);
     assertErrors(source, [HintCode.TYPE_CHECK_IS_NULL]);
@@ skipping 1202 matching lines @@
     assertNoErrors(source2);
     verify([source, source2]);
   }
 
   void test_unusedShownName() {
     Source source = addSource(r'''
 library L;
 import 'lib1.dart' show A, B;
 A a;''');
     Source source2 = addNamedSource(
-        "/lib1.dart", r'''
+        "/lib1.dart",
+        r'''
 library lib1;
 class A {}
 class B {}''');
     computeLibrarySourceErrors(source);
     assertErrors(source, [HintCode.UNUSED_SHOWN_NAME]);
     assertNoErrors(source2);
     verify([source, source2]);
   }
 
   void test_unusedShownName_topLevelVariable() {
@@ skipping 17 matching lines @@
     assertNoErrors(source2);
     verify([source, source2]);
   }
 
   void test_unusedShownName_as() {
     Source source = addSource(r'''
 library L;
 import 'lib1.dart' as p show A, B;
 p.A a;''');
     Source source2 = addNamedSource(
-        "/lib1.dart", r'''
+        "/lib1.dart",
+        r'''
 library lib1;
 class A {}
 class B {}''');
     computeLibrarySourceErrors(source);
     assertErrors(source, [HintCode.UNUSED_SHOWN_NAME]);
     assertNoErrors(source2);
     verify([source, source2]);
   }
 
   void test_unusedShownName_duplicates() {
     Source source = addSource(r'''
 library L;
 import 'lib1.dart' show A, B;
 import 'lib1.dart' show C, D;
 A a;
 C c;''');
     Source source2 = addNamedSource(
-        "/lib1.dart", r'''
+        "/lib1.dart",
+        r'''
 library lib1;
 class A {}
 class B {}
 class C {}
 class D {}''');
     computeLibrarySourceErrors(source);
-    assertErrors(source, [
-        HintCode.UNUSED_SHOWN_NAME,
-        HintCode.UNUSED_SHOWN_NAME]);
+    assertErrors(
+        source, [HintCode.UNUSED_SHOWN_NAME, HintCode.UNUSED_SHOWN_NAME]);
     assertNoErrors(source2);
     verify([source, source2]);
   }
 
   void test_unusedLocalVariable_inCatch_exception() {
     enableUnusedLocalVariable = true;
     Source source = addSource(r'''
 main() {
   try {
   } on String catch (exception) {
@@ skipping 252 matching lines @@
   n() {
     var a = m(), b = m();
   }
 }''');
     computeLibrarySourceErrors(source);
     assertErrors(
         source, [HintCode.USE_OF_VOID_RESULT, HintCode.USE_OF_VOID_RESULT]);
     verify([source]);
   }
 }