Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1897293003: Required params message fix. (Closed)

Created:
4 years, 8 months ago by pquitslund
Modified:
4 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Required params message fix. Gets rid of the rogue space when no details are provided in the `@Required` constructor. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/433fd4558d3491799567b33a597a05a34b14cf8c

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -14 lines) Patch
M pkg/analyzer/lib/src/generated/error.dart View 2 chunks +13 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +10 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 6 chunks +11 lines, -9 lines 4 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
4 years, 8 months ago (2016-04-19 17:49:38 UTC) #2
Brian Wilkerson
lgtm https://codereview.chromium.org/1897293003/diff/1/pkg/analyzer/test/generated/hint_code_test.dart File pkg/analyzer/test/generated/hint_code_test.dart (right): https://codereview.chromium.org/1897293003/diff/1/pkg/analyzer/test/generated/hint_code_test.dart#newcode1608 pkg/analyzer/test/generated/hint_code_test.dart:1608: assertErrors(source, [HintCode.MISSING_REQUIRED_PARAM_WITH_DETAILS]); It would be good to have ...
4 years, 8 months ago (2016-04-19 18:01:16 UTC) #3
pquitslund
Thanks! https://codereview.chromium.org/1897293003/diff/1/pkg/analyzer/test/generated/hint_code_test.dart File pkg/analyzer/test/generated/hint_code_test.dart (right): https://codereview.chromium.org/1897293003/diff/1/pkg/analyzer/test/generated/hint_code_test.dart#newcode1608 pkg/analyzer/test/generated/hint_code_test.dart:1608: assertErrors(source, [HintCode.MISSING_REQUIRED_PARAM_WITH_DETAILS]); On 2016/04/19 18:01:16, Brian Wilkerson wrote: ...
4 years, 8 months ago (2016-04-19 18:20:24 UTC) #4
pquitslund
4 years, 8 months ago (2016-04-19 18:21:14 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
433fd4558d3491799567b33a597a05a34b14cf8c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698