third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp - Issue 1897263002: Hoist transformToRootChanged() out of SVGLayoutSupport::layoutChildren

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp

Issue 1897263002: Hoist transformToRootChanged() out of SVGLayoutSupport::layoutChildren (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@svg-container-layout-cleanup-1

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp

index 329a8b53c8c7fde7573524709beec57c46605d8e..3961d888d0349e6063e00be58bc349481b706f29 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp

@@ -33,7 +33,9 @@ void LayoutSVGHiddenContainer::layout()

{

ASSERT(needsLayout());

LayoutAnalyzer::Scope analyzer(*this);

- SVGLayoutSupport::layoutChildren(this, selfNeedsLayout());

+ // TODO(fs): In what cases do we need this?

+ bool transformChanged = SVGLayoutSupport::transformToRootChanged(this);

+ SVGLayoutSupport::layoutChildren(this, selfNeedsLayout(), transformChanged);

pdr. 2016/04/19 18:53:44 Can you remove this and see what tests fail, and f

fs 2016/04/19 19:39:56 Yepp, I intend to.

updateCachedBoundaries();

clearNeedsLayout();

}