Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issue 189723004: DevTools: console evaluation should work when window.console is overriden. (Closed)

Created:
6 years, 9 months ago by pfeldman
Modified:
6 years, 9 months ago
Reviewers:
vsevik, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: console evaluation should work when window.console is overriden. BUG=349993 R=yurys@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168723

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M LayoutTests/inspector/console/console-native-function-to-string.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-substituted.html View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/inspector/InjectedScriptSource.js View 2 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pfeldman
6 years, 9 months ago (2014-03-07 05:46:28 UTC) #1
yurys
https://codereview.chromium.org/189723004/diff/1/Source/core/inspector/InjectedScriptSource.js File Source/core/inspector/InjectedScriptSource.js (right): https://codereview.chromium.org/189723004/diff/1/Source/core/inspector/InjectedScriptSource.js#newcode617 Source/core/inspector/InjectedScriptSource.js:617: injectCommandLineAPI = injectCommandLineAPI && !("__commandLineAPI" in inspectedWindow); How is ...
6 years, 9 months ago (2014-03-07 07:23:27 UTC) #2
pfeldman
"name" in object returns true for non-enumerable. I'll update the test w/ this case.
6 years, 9 months ago (2014-03-07 08:12:13 UTC) #3
yurys
lgtm
6 years, 9 months ago (2014-03-07 09:10:31 UTC) #4
pfeldman
6 years, 9 months ago (2014-03-07 09:12:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r168723 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698