Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1897213002: Fix GN freeze on generating Visual Studio projects (Closed)

Created:
4 years, 8 months ago by Tomasz Moniuszko
Modified:
4 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GN freeze on generating Visual Studio projects There's an infinite loop while searching for parent directory. It happens when drive letter case is mixed in absolute paths on Windows (/C:/foo and /c:/foo). It's easily reproducible on MSYS terminals when system-absolute paths are used for some targets and source root-absolute (//foo/bar) paths are used for other targets. BUG= Committed: https://crrev.com/e4b98e2d9ff4fceae0d515d5795e677ff4518223 Cr-Commit-Position: refs/heads/master@{#388443}

Patch Set 1 #

Patch Set 2 : Rebase patch onto current master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M tools/gn/visual_studio_writer.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M tools/gn/visual_studio_writer_unittest.cc View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Tomasz Moniuszko
4 years, 8 months ago (2016-04-19 10:35:35 UTC) #2
brettw
lgtm
4 years, 8 months ago (2016-04-19 17:55:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897213002/1
4 years, 8 months ago (2016-04-19 22:28:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn/builds/21792) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-19 22:31:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897213002/20001
4 years, 8 months ago (2016-04-20 07:38:12 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-20 08:17:51 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:21:31 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e4b98e2d9ff4fceae0d515d5795e677ff4518223
Cr-Commit-Position: refs/heads/master@{#388443}

Powered by Google App Engine
This is Rietveld 408576698