Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: tools/gn/visual_studio_writer_unittest.cc

Issue 1897213002: Fix GN freeze on generating Visual Studio projects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase patch onto current master Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/visual_studio_writer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/visual_studio_writer_unittest.cc
diff --git a/tools/gn/visual_studio_writer_unittest.cc b/tools/gn/visual_studio_writer_unittest.cc
index 16e327b8f12521bcb698f624344db4de634c7f04..f89c1c193f3e6364f520bf9bac38bd80b433ee49 100644
--- a/tools/gn/visual_studio_writer_unittest.cc
+++ b/tools/gn/visual_studio_writer_unittest.cc
@@ -4,6 +4,7 @@
#include "tools/gn/visual_studio_writer.h"
+#include "base/strings/string_util.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "tools/gn/test_with_scope.h"
#include "tools/gn/visual_studio_utils.h"
@@ -100,11 +101,15 @@ TEST_F(VisualStudioWriterTest, ResolveSolutionFolders_AbsPath) {
"bar", path, MakeGuid(path, "project"), MakeTestPath("/foo/bar"),
"Win32"));
+ std::string baz_label_dir_path = MakeTestPath("/foo/bar/baz");
+#if defined(OS_WIN)
+ // Make sure mixed lower and upper-case drive letters are handled properly.
+ baz_label_dir_path[0] = base::ToLowerASCII(baz_label_dir_path[0]);
+#endif
path = MakeTestPath(
"/foo/chromium/src/out/Debug/obj/ABS_PATH/C/foo/bar/baz/baz.vcxproj");
writer.projects_.emplace_back(new VisualStudioWriter::SolutionProject(
- "baz", path, MakeGuid(path, "project"), MakeTestPath("/foo/bar/baz"),
- "Win32"));
+ "baz", path, MakeGuid(path, "project"), baz_label_dir_path, "Win32"));
writer.ResolveSolutionFolders();
« no previous file with comments | « tools/gn/visual_studio_writer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698