Detach ArrayBuffer in test262

test/test262/testcfg.py

Index: test/test262/testcfg.py
diff --git a/test/test262/testcfg.py b/test/test262/testcfg.py
index bf007bd46ffabfaab1fba04e54fa4c5f026d5f81..fd1a8709996c838b05769d26f0c79e311ec803ed 100644
--- a/test/test262/testcfg.py
+++ b/test/test262/testcfg.py
@@ -43,6 +43,7 @@ DATA = os.path.join(os.path.dirname(os.path.abspath(__file__)), "data")
 ARCHIVE = DATA + ".tar"
 
 TEST_262_HARNESS_FILES = ["sta.js", "assert.js"]
+TEST_262_NATIVE_FILES = ["detachArrayBuffer.js"]
 
 TEST_262_SUITE_PATH = ["data", "test"]
 TEST_262_HARNESS_PATH = ["data", "harness"]
@@ -130,7 +131,12 @@ class Test262TestSuite(testsuite.TestSuite):
     return (testcase.flags + context.mode_flags + self.harness +
             self.GetIncludesForTest(testcase) + ["--harmony"] +
             [os.path.join(self.testroot, testcase.path + ".js")] +
-            (["--throws"] if "negative" in self.GetTestRecord(testcase) else []))
+            (["--throws"] if "negative" in self.GetTestRecord(testcase)
+                          else []) +
+            (["--allow-natives-syntax"]
+             if "detachArrayBuffer.js" in

[Michael Achenbach, 2016/04/20 07:53:45]

Just a question to understand how this is all patched together: How does
detachArrayBuffer.js get into the includes? Is this part of test262 upstream?

[Dan Ehrenberg, 2016/04/20 19:19:03]

Yes, test262 upstream adds new tests which include this file, and a default
definition (which simply throws).

+                self.GetTestRecord(testcase).get("includes", [])
+             else []))
 
   def _VariantGeneratorFactory(self):
     return Test262VariantGenerator
@@ -161,7 +167,10 @@ class Test262TestSuite(testsuite.TestSuite):
   def GetIncludesForTest(self, testcase):
     test_record = self.GetTestRecord(testcase)
     if "includes" in test_record:
-      includes = [os.path.join(self.harnesspath, f)
+      includes = [os.path.join(self.root

[Michael Achenbach, 2016/04/20 07:53:45]

nit: maybe less nesting and a local var for readability? And the other condition
could be dropped too:

test_record = self.GetTestRecord(testcase)
base_path = lambda f: (self.root if f in TEST_262_NATIVE_FILES
                       else self.harnesspath)
return [os.path.join(base_path(f), f)
        for f in test_record.get("includes", [])]

[Dan Ehrenberg, 2016/04/20 19:19:03]

Factored out a separate BasePath method for this purpose.

+                                 if f in TEST_262_NATIVE_FILES
+                                 else self.harnesspath,
+                               f)
                   for f in test_record["includes"]]
     else:
       includes = []