Detach ArrayBuffer in test262

test/test262/testcfg.py

 # Copyright 2012 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 25 matching lines @@
 
 from testrunner.local import statusfile
 from testrunner.local import testsuite
 from testrunner.local import utils
 from testrunner.objects import testcase
 
 DATA = os.path.join(os.path.dirname(os.path.abspath(__file__)), "data")
 ARCHIVE = DATA + ".tar"
 
 TEST_262_HARNESS_FILES = ["sta.js", "assert.js"]
+TEST_262_NATIVE_FILES = ["detachArrayBuffer.js"]
 
 TEST_262_SUITE_PATH = ["data", "test"]
 TEST_262_HARNESS_PATH = ["data", "harness"]
 TEST_262_TOOLS_PATH = ["data", "tools", "packaging"]
 
 ALL_VARIANT_FLAGS_STRICT = dict(
     (v, [flags + ["--use-strict"] for flags in flag_sets])
     for v, flag_sets in testsuite.ALL_VARIANT_FLAGS.iteritems()
 )
 
@@ skipping 67 matching lines @@
           relpath = fullpath[len(self.testroot) + 1 : -3]
           testname = relpath.replace(os.path.sep, "/")
           case = testcase.TestCase(self, testname)
           tests.append(case)
     return tests
 
   def GetFlagsForTestCase(self, testcase, context):
     return (testcase.flags + context.mode_flags + self.harness +
             self.GetIncludesForTest(testcase) + ["--harmony"] +
             [os.path.join(self.testroot, testcase.path + ".js")] +
-            (["--throws"] if "negative" in self.GetTestRecord(testcase) else []))
+            (["--throws"] if "negative" in self.GetTestRecord(testcase)
+                          else []) +
+            (["--allow-natives-syntax"]
+             if "detachArrayBuffer.js" in

[Michael Achenbach, 2016/04/20 07:53:45]

Just a question to understand how this is all patched together: How does
detachArrayBuffer.js get into the includes? Is this part of test262 upstream?

[Dan Ehrenberg, 2016/04/20 19:19:03]

Yes, test262 upstream adds new tests which include this file, and a default
definition (which simply throws).

+                self.GetTestRecord(testcase).get("includes", [])
+             else []))
 
   def _VariantGeneratorFactory(self):
     return Test262VariantGenerator
 
   def LoadParseTestRecord(self):
     if not self.ParseTestRecord:
       root = os.path.join(self.root, *TEST_262_TOOLS_PATH)
       f = None
       try:
         (f, pathname, description) = imp.find_module("parseTestRecord", [root])
@@ skipping 10 matching lines @@
   def GetTestRecord(self, testcase):
     if not hasattr(testcase, "test_record"):
       ParseTestRecord = self.LoadParseTestRecord()
       testcase.test_record = ParseTestRecord(self.GetSourceForTest(testcase),
                                              testcase.path)
     return testcase.test_record
 
   def GetIncludesForTest(self, testcase):
     test_record = self.GetTestRecord(testcase)
     if "includes" in test_record:
-      includes = [os.path.join(self.harnesspath, f)
+      includes = [os.path.join(self.root

[Michael Achenbach, 2016/04/20 07:53:45]

nit: maybe less nesting and a local var for readability? And the other condition
could be dropped too:

test_record = self.GetTestRecord(testcase)
base_path = lambda f: (self.root if f in TEST_262_NATIVE_FILES
                       else self.harnesspath)
return [os.path.join(base_path(f), f)
        for f in test_record.get("includes", [])]

[Dan Ehrenberg, 2016/04/20 19:19:03]

Factored out a separate BasePath method for this purpose.

+                                 if f in TEST_262_NATIVE_FILES
+                                 else self.harnesspath,
+                               f)
                   for f in test_record["includes"]]
     else:
       includes = []
     return includes
 
   def GetSourceForTest(self, testcase):
     filename = os.path.join(self.testroot, testcase.path + ".js")
     with open(filename) as f:
       return f.read()
 
@@ skipping 39 matching lines @@
     # data folder.
     if os.path.exists(ARCHIVE) and not os.path.exists(DATA):
       print "Extracting archive..."
       tar = tarfile.open(ARCHIVE)
       tar.extractall(path=os.path.dirname(ARCHIVE))
       tar.close()
 
 
 def GetSuite(name, root):
   return Test262TestSuite(name, root)