Detach ArrayBuffer in test262

Detach ArrayBuffer in test262

New incoming test262 tests check what happens on detached ("neutered")
ArrayBuffers. This patch makes the test262 infrastructure define
detaching an ArrayBuffer in terms of %ArrayBufferNeuter, passing the
--allow-natives-syntax flag, when it is needed.

BUG=v8:4193
LOG=N
R=adamk,machenbach

Committed: https://crrev.com/f32e30240da12a4cdaabc4033917f836cc0bcbf5
Cr-Commit-Position: refs/heads/master@{#35676}

[Dan Ehrenberg, 2016-04-20 01:31:10]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 01:31:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1897203003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1897203003/1

[commit-bot: I haz the power, 2016-04-20 01:36:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 01:36:28]

Dry run: Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13878)

[Michael Achenbach, 2016-04-20 07:53:45]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2016-04-20 07:53:46]

lgtm with comments/questions.

https://codereview.chromium.org/1897203003/diff/1/test/test262/testcfg.py
File test/test262/testcfg.py (right):

https://codereview.chromium.org/1897203003/diff/1/test/test262/testcfg.py#new...
test/test262/testcfg.py:137: if "detachArrayBuffer.js" in
Just a question to understand how this is all patched together: How does
detachArrayBuffer.js get into the includes? Is this part of test262 upstream?

https://codereview.chromium.org/1897203003/diff/1/test/test262/testcfg.py#new...
test/test262/testcfg.py:170: includes = [os.path.join(self.root
nit: maybe less nesting and a local var for readability? And the other condition
could be dropped too:

test_record = self.GetTestRecord(testcase)
base_path = lambda f: (self.root if f in TEST_262_NATIVE_FILES
                       else self.harnesspath)
return [os.path.join(base_path(f), f)
        for f in test_record.get("includes", [])]

[Dan Ehrenberg, 2016-04-20 19:19:02]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-04-20 19:19:03]

https://codereview.chromium.org/1897203003/diff/1/test/test262/testcfg.py
File test/test262/testcfg.py (right):

https://codereview.chromium.org/1897203003/diff/1/test/test262/testcfg.py#new...
test/test262/testcfg.py:137: if "detachArrayBuffer.js" in
On 2016/04/20 at 07:53:45, Michael Achenbach wrote:
> Just a question to understand how this is all patched together: How does
detachArrayBuffer.js get into the includes? Is this part of test262 upstream?

Yes, test262 upstream adds new tests which include this file, and a default
definition (which simply throws).

https://codereview.chromium.org/1897203003/diff/1/test/test262/testcfg.py#new...
test/test262/testcfg.py:170: includes = [os.path.join(self.root
On 2016/04/20 at 07:53:45, Michael Achenbach wrote:
> nit: maybe less nesting and a local var for readability? And the other
condition could be dropped too:
> 
> test_record = self.GetTestRecord(testcase)
> base_path = lambda f: (self.root if f in TEST_262_NATIVE_FILES
>                        else self.harnesspath)
> return [os.path.join(base_path(f), f)
>         for f in test_record.get("includes", [])]

Factored out a separate BasePath method for this purpose.

[Dan Ehrenberg, 2016-04-20 19:19:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/1897203003/#ps20001
(title: "Refactoring")

[commit-bot: I haz the power, 2016-04-20 19:19:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1897203003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1897203003/20001

[commit-bot: I haz the power, 2016-04-20 19:43:00]

Committed patchset #2 (id:20001)

[Michael Achenbach, 2016-04-21 07:23:49]

https://codereview.chromium.org/1897203003/diff/20001/test/test262/testcfg.py
File test/test262/testcfg.py (right):

https://codereview.chromium.org/1897203003/diff/20001/test/test262/testcfg.py...
test/test262/testcfg.py:175: for filename in test_record.get("includes", [])]
But you didn't fully add the other simplification I suggested, or is it wrong?
If you add the [] default to test_record.get, the resulting list comprehension
will create an empty list too if "includes" is not in test_record. So the whole
code could be:

test_record = self.GetTestRecord(testcase)
return [os.path.join(self.BasePath(filename), filename)
  for filename in test_record.get("includes", [])]

And that's it.

[Dan Ehrenberg, 2016-04-21 07:29:36]

https://codereview.chromium.org/1897203003/diff/20001/test/test262/testcfg.py
File test/test262/testcfg.py (right):

https://codereview.chromium.org/1897203003/diff/20001/test/test262/testcfg.py...
test/test262/testcfg.py:175: for filename in test_record.get("includes", [])]
On 2016/04/21 at 07:23:49, Michael Achenbach wrote:
> But you didn't fully add the other simplification I suggested, or is it wrong?
If you add the [] default to test_record.get, the resulting list comprehension
will create an empty list too if "includes" is not in test_record. So the whole
code could be:
> 
> test_record = self.GetTestRecord(testcase)
> return [os.path.join(self.BasePath(filename), filename)
>   for filename in test_record.get("includes", [])]
> 
> And that's it.

Oh, I misunderstood somehow. I'll do this in a follow-on patch.

[commit-bot: I haz the power, 2016-04-22 19:13:46]

Description was changed from

==========
Detach ArrayBuffer in test262

New incoming test262 tests check what happens on detached ("neutered")
ArrayBuffers. This patch makes the test262 infrastructure define
detaching an ArrayBuffer in terms of %ArrayBufferNeuter, passing the
--allow-natives-syntax flag, when it is needed.

BUG=v8:4193
LOG=N
R=adamk,machenbach
==========

to

==========
Detach ArrayBuffer in test262

New incoming test262 tests check what happens on detached ("neutered")
ArrayBuffers. This patch makes the test262 infrastructure define
detaching an ArrayBuffer in terms of %ArrayBufferNeuter, passing the
--allow-natives-syntax flag, when it is needed.

BUG=v8:4193
LOG=N
R=adamk,machenbach

Committed: https://crrev.com/f32e30240da12a4cdaabc4033917f836cc0bcbf5
Cr-Commit-Position: refs/heads/master@{#35676}
==========

[commit-bot: I haz the power, 2016-04-22 19:13:47]

Patchset 2 (id:??) landed as
https://crrev.com/f32e30240da12a4cdaabc4033917f836cc0bcbf5
Cr-Commit-Position: refs/heads/master@{#35676}