third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp - Issue 1897193002: Worker: Rename worker components to clarify what they work for (part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

Issue 1897193002: Worker: Rename worker components to clarify what they work for (part 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp ('k') | third_party/WebKit/Source/core/workers/WorkerObjectProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

diff --git a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

index ee7ae4c7364d7cd980382194cbbd879bc1dcf528..ffbced6bc2c2225904e724cfbc8441d15e815c48 100644

--- a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

+++ b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

@@ -343,12 +343,14 @@ void WorkerGlobalScope::deregisterEventListener(V8AbstractEventListener* eventLi

void WorkerGlobalScope::countFeature(UseCounter::Feature) const

{

- // FIXME: How should we count features for shared/service workers?

+ // TODO(nhiroki): How should we count features for shared/service workers?

+ // (http://crbug.com/376039)

}

void WorkerGlobalScope::countDeprecation(UseCounter::Feature feature) const

{

- // FIXME: How should we count features for shared/service workers?

+ // TODO(nhiroki): How should we count features for shared/service workers?

+ // (http://crbug.com/376039)

ASSERT(isSharedWorkerGlobalScope() || isServiceWorkerGlobalScope() || isCompositorWorkerGlobalScope());

// For each deprecated feature, send console message at most once