Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1897143003: X87: [Atomics] Remove Atomics code stubs; use TF ops. (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [Atomics] Remove Atomics code stubs; use TF ops. port d412cfa26c18a6ef1f6c0e274ee51f3d834eab74 (r35596) original commit message: Reland of (https://codereview.chromium.org/1891033002) This is a much cleaner solution, which won't require nearly as much architecture-specific code. Thanks bmeurer@! BUG= Committed: https://crrev.com/ce3f9afabaaa17ec9f06bf3ee3461ad9f0b68de9 Cr-Commit-Position: refs/heads/master@{#35603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -200 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -191 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-04-19 02:37:50 UTC) #2
Weiliang
lgtm
4 years, 8 months ago (2016-04-19 05:53:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897143003/1
4 years, 8 months ago (2016-04-19 06:16:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 06:34:29 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 06:35:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce3f9afabaaa17ec9f06bf3ee3461ad9f0b68de9
Cr-Commit-Position: refs/heads/master@{#35603}

Powered by Google App Engine
This is Rietveld 408576698